chore(terminal): remove migrated terminal code - #7243
Open
mlhiter wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
area/cloud
area/ci
area/test
area/frontend
area/workflow
labels
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the migrated Terminal frontend and controller implementation from the monorepo, including its charts, CRD, assets, and dependency entries. Update frontend/controller build, module detection, installation, app catalog, and admission whitelist references so CI and deployment no longer target deleted paths.
Validation
Passed frozen pnpm lockfile installation,
controllers/go.workparsing,git diff --check, and frontend workflow YAML parsing. No repository-wide automated test command was found;scripts/detect-build-modules.shrequires Bash 4+ and cannot be syntax-checked by macOS Bash 3.2.Sequence Diagram
sequenceDiagram participant Root as Root configuration participant FrontendCI as Frontend CI participant ControllerCI as Controller module detection participant Repo as Repository paths Root->>FrontendCI: Evaluate changed files and build matrix Root->>ControllerCI: Resolve controller modules FrontendCI->>Repo: Build existing frontend targets ControllerCI->>Repo: Build existing controller targets Repo-->>FrontendCI: Terminal target absent from build path Repo-->>ControllerCI: Terminal module absent from module path