From 21ef4eb0e7eda8cc1192a9d176f82dbed239d015 Mon Sep 17 00:00:00 2001 From: Eyji Date: Mon, 19 Oct 2026 20:35:57 +0200 Subject: [PATCH] feat(audible): optional filter for other-language editions in search, BookDate and shelf sync Keyword search on the catalog API returns every language, so on a non-English region search, BookDate and shelf sync can surface (and request) editions that are not in the region's language. New admin setting `audible.language_filter` (off by default), a checkbox under the Audible region in Settings > Library. When on, `search()` drops products whose language fails `isAcceptedLanguage()` for the region, for callers that pass `respectLanguageFilter`. Bulk import does not, since it matches files on disk. Refs #259 Co-Authored-By: Claude Opus 5.5 --- documentation/features/bookdate.md | 2 +- documentation/integrations/audible.md | 9 ++ documentation/settings-pages.md | 15 ++- src/app/admin/settings/lib/helpers.ts | 7 +- src/app/admin/settings/lib/types.ts | 1 + .../AudibleLanguageFilterOption.tsx | 33 +++++++ .../tabs/LibraryTab/AudiobookshelfSection.tsx | 2 + .../settings/tabs/LibraryTab/PlexSection.tsx | 2 + src/app/api/admin/settings/audible/route.ts | 27 +++++- src/app/api/admin/settings/route.ts | 1 + src/app/api/audiobooks/search/route.ts | 2 +- src/lib/bookdate/helpers.ts | 2 +- src/lib/integrations/audible.service.ts | 32 ++++++- src/lib/services/config.service.ts | 7 ++ src/lib/services/shelf-sync-core.service.ts | 4 +- .../api/admin-settings-audible.routes.test.ts | 94 +++++++++++++++++++ tests/api/admin-settings-core.routes.test.ts | 13 +-- tests/api/audiobooks-browse.routes.test.ts | 1 + tests/app/admin-settings.page.test.tsx | 1 + .../admin/settings/hooks/useSettings.test.tsx | 1 + tests/app/admin/settings/lib/helpers.test.ts | 6 +- .../AudibleLanguageFilterOption.test.tsx | 27 ++++++ tests/bookdate/helpers.test.ts | 4 +- .../admin-settings-indexers.test.tsx | 1 + tests/integrations/audible.service.test.ts | 59 ++++++++++++ .../services/shelf-sync-core.service.test.ts | 57 +++++++++++ 26 files changed, 376 insertions(+), 34 deletions(-) create mode 100644 src/app/admin/settings/tabs/LibraryTab/AudibleLanguageFilterOption.tsx create mode 100644 tests/api/admin-settings-audible.routes.test.ts create mode 100644 tests/app/admin/settings/tabs/LibraryTab/AudibleLanguageFilterOption.test.tsx create mode 100644 tests/services/shelf-sync-core.service.test.ts diff --git a/documentation/features/bookdate.md b/documentation/features/bookdate.md index 372ed0380..10db503b0 100644 --- a/documentation/features/bookdate.md +++ b/documentation/features/bookdate.md @@ -150,7 +150,7 @@ Personalized audiobook discovery using OpenAI/Claude APIs. Admin configures AI p - Request: 20 recommendations (expect ~10 after filtering) 3. **Post-Processing:** - - Match to Audnexus (database cache first, API fallback) + - Match to Audnexus (database cache first, API fallback: first Audible search result, filtered by `audible.language_filter` when on) - Filter: Already in library (uses centralized audiobook-matcher.ts - same as homepage), already requested, already swiped - Two-stage library filtering: - Stage 1: Fuzzy match with AI-provided title/author (before Audnexus) diff --git a/documentation/integrations/audible.md b/documentation/integrations/audible.md index 7c76c858f..0972ac8dd 100644 --- a/documentation/integrations/audible.md +++ b/documentation/integrations/audible.md @@ -61,6 +61,7 @@ Populates every `AudibleAudiobook` field. Covered: - **Catalog API cannot filter preorders or surface curated bestsellers.** The API's `BestSellers` sort is a right-now velocity rank that spikes on launch-day promos and preorder windows; the `-ReleaseDate` sort returns 100% future preorders. There is no server-side `release_time`, `released-only`, `customer_rights`, or alternate sort (`Reviewed`, `MostListened`, etc.) — every plausible variant was tested and silently ignored. This is why the nightly refresh job uses the curated HTML storefront pages instead. - **`author=` takes a name, not an ASIN.** The catalog API has no ASIN-based author param. `searchByAuthorAsin()` queries by name, then filters client-side: keeps only products where `products[].authors[].asin === authorAsin`. Preserves ASIN-authoritative author identity. Also filters by `product.language` via `isAcceptedLanguage()` for the configured region. +- **Keyword search returns every language.** `search()` sends no language param, so results include editions in languages other than the region's. Opt-in filter, see Language Filter below. - **Invalid ASIN returns HTTP 200 with stub body.** `/1.0/catalog/products/{asin}` responds 200 with `{product: {asin: INPUT}}` and no other fields. `fetchAudibleDetailsFromApi()` detects this via missing `product.title` and returns `null`. - **`publisher_summary` is HTML.** Service strips tags via inline `stripHtml()` helper (regex-based, no cheerio) before populating `description`. Falls back to `merchandising_summary` (plain text) if `publisher_summary` missing. - **Series is an array.** `products[].series[]` — a book may belong to multiple series. Service picks the first entry with non-empty `sequence`, else the first entry. `sequence` is cleaned by extracting first `/\d+(?:\.\d+)?/` match for numeric ordering. @@ -111,6 +112,14 @@ Configurable Audible region for accurate metadata matching across international - Cache clearing: Region change clears ConfigService cache and AudibleService state. - Automatic refresh: Region change triggers `audible_refresh` job. +**Language Filter:** +- Key: `audible.language_filter` (`'true'`/`'false'`, default off). Read via `ConfigService.getAudibleLanguageFilter()`. +- `search(query, page, { respectLanguageFilter: true })`: when the key is on, drops products whose `language` fails `isAcceptedLanguage()` for the region. Products without `language` are kept. +- Opted in: search page (`/api/audiobooks/search`), BookDate (`matchToAudnexus`), shelf sync (`performAudibleLookup`). Not opted in: bulk import (matches files already on disk). +- Shelf sync: a book with no edition in the region's language becomes a `noMatch` mapping (retried every 7 days). Mappings resolved before the filter was enabled are not re-resolved. +- `hasMore` is computed on the raw page, so a page whose books were all filtered out does not end pagination for API callers. `totalResults` stays Audible's unfiltered total. +- Discovery pages (popular, new releases, categories) are not filtered: they come from the region's HTML storefronts, not keyword search. + **Per-region HTTP clients (on init):** - `apiClient` — `baseURL=apiBaseUrl`, `Accept: application/json`, `User-Agent: ReadMeABook/1.0`, no language/ipRedirect params. Used for the real-time JSON catalog operations (search, author books, categories listing, per-ASIN details fallback). - `htmlClient` — `baseURL=baseUrl`, rotating browser headers (`pickUserAgent` + `getBrowserHeaders`), default params `ipRedirectOverride=true` + `language=`. Used by the nightly discovery refresh (`/adblbestsellers`, `/newreleases`, `/search?node=...`), by `audible-series.ts`, and by `getBaseUrl()`-based link generation. diff --git a/documentation/settings-pages.md b/documentation/settings-pages.md index ef89fa981..dd1d4e897 100644 --- a/documentation/settings-pages.md +++ b/documentation/settings-pages.md @@ -64,8 +64,8 @@ src/app/admin/settings/ ## Sections -1. **Plex** - URL, token (masked), library ID, Audible region, filesystem scan trigger toggle -2. **Audiobookshelf** - URL, API token (masked), library ID, Audible region, filesystem scan trigger toggle +1. **Plex** - URL, token (masked), library ID, Audible region, language filter toggle, filesystem scan trigger toggle +2. **Audiobookshelf** - URL, API token (masked), library ID, Audible region, language filter toggle, filesystem scan trigger toggle 3. **Prowlarr** - URL, API key (masked), indexer selection with priority, seeding time, RSS monitoring toggle, **audiobook/ebook categories per indexer** 4. **Download Client** - Type (qBittorrent, Transmission, SABnzbd), URL, credentials (masked), custom download path (per-client relative sub-path with live preview) 5. **Paths** - Download + media directories, audiobook organization template, metadata tagging toggle, chapter merging toggle, Plex format coercion toggle @@ -176,6 +176,11 @@ src/app/admin/settings/ - **Smart re-initialization**: Service automatically detects region changes and re-initializes before each request - See: `documentation/integrations/audible.md` for technical details +**Language filter toggle** ("Only show books in the region's language"): +- Key: `audible.language_filter` (boolean as string, default off) +- UI: `AudibleLanguageFilterOption` checkbox under the region dropdown, shared by both sections +- Effect: hides other-language editions from search, BookDate and shelf sync. See `documentation/integrations/audible.md#region-configuration` + ## Audiobook Organization Template **Purpose:** Customize how audiobooks are organized within the media directory using variable-based templates. @@ -310,9 +315,9 @@ src/app/admin/settings/ - Requires prior successful test if values changed **PUT /api/admin/settings/audible** -- Updates Audible region -- Body: `{ region: string }` (one of: us, ca, uk, au, in, es, fr) -- No validation required +- Updates Audible region and, when sent, the language filter +- Body: `{ region: string, languageFilter?: boolean }` (region one of: us, ca, uk, au, in, es, fr) +- 400 if `region` is invalid or `languageFilter` is not a boolean; omitted `languageFilter` leaves the stored value unchanged **PUT /api/admin/settings/prowlarr/indexers** - Updates indexer configuration (enabled, priority, seeding time, RSS) diff --git a/src/app/admin/settings/lib/helpers.ts b/src/app/admin/settings/lib/helpers.ts index e210b3133..69199a84e 100644 --- a/src/app/admin/settings/lib/helpers.ts +++ b/src/app/admin/settings/lib/helpers.ts @@ -39,11 +39,14 @@ export const saveTabSettings = async ( ): Promise => { switch (activeTab) { case 'library': - // Save Audible region + // Save Audible region and language filter await fetchWithAuth('/api/admin/settings/audible', { method: 'PUT', headers: { 'Content-Type': 'application/json' }, - body: JSON.stringify({ region: settings.audibleRegion }), + body: JSON.stringify({ + region: settings.audibleRegion, + languageFilter: settings.audibleLanguageFilter, + }), }).then(res => { if (!res.ok) throw new Error('Failed to save Audible region settings'); }); diff --git a/src/app/admin/settings/lib/types.ts b/src/app/admin/settings/lib/types.ts index 46b4ab46f..58cface28 100644 --- a/src/app/admin/settings/lib/types.ts +++ b/src/app/admin/settings/lib/types.ts @@ -11,6 +11,7 @@ export interface Settings { hasLocalUsers: boolean; hasLocalAdmins: boolean; audibleRegion: string; + audibleLanguageFilter: boolean; plex: PlexSettings; audiobookshelf: AudiobookshelfSettings; oidc: OIDCSettings; diff --git a/src/app/admin/settings/tabs/LibraryTab/AudibleLanguageFilterOption.tsx b/src/app/admin/settings/tabs/LibraryTab/AudibleLanguageFilterOption.tsx new file mode 100644 index 000000000..564f42c77 --- /dev/null +++ b/src/app/admin/settings/tabs/LibraryTab/AudibleLanguageFilterOption.tsx @@ -0,0 +1,33 @@ +/** + * Component: Audible Language Filter Toggle + * Documentation: documentation/settings-pages.md + */ + +import { Settings } from '../../lib/types'; + +interface AudibleLanguageFilterOptionProps { + settings: Settings; + onChange: (settings: Settings) => void; +} + +export function AudibleLanguageFilterOption({ settings, onChange }: AudibleLanguageFilterOptionProps) { + return ( + + ); +} diff --git a/src/app/admin/settings/tabs/LibraryTab/AudiobookshelfSection.tsx b/src/app/admin/settings/tabs/LibraryTab/AudiobookshelfSection.tsx index 46e6c8e9d..82ae5e89e 100644 --- a/src/app/admin/settings/tabs/LibraryTab/AudiobookshelfSection.tsx +++ b/src/app/admin/settings/tabs/LibraryTab/AudiobookshelfSection.tsx @@ -7,6 +7,7 @@ import { Input } from '@/components/ui/Input'; import { Button } from '@/components/ui/Button'; import { Settings, ABSLibrary } from '../../lib/types'; import { AUDIBLE_REGIONS } from '@/lib/types/audible'; +import { AudibleLanguageFilterOption } from './AudibleLanguageFilterOption'; interface AudiobookshelfSectionProps { settings: Settings; @@ -199,6 +200,7 @@ export function AudiobookshelfSection({ Select the Audible region that matches your metadata engine (Audnexus/Audible Agent) configuration in Audiobookshelf. This ensures accurate book matching and metadata.

+
diff --git a/src/app/admin/settings/tabs/LibraryTab/PlexSection.tsx b/src/app/admin/settings/tabs/LibraryTab/PlexSection.tsx index 3ad225530..d9e4e8ec1 100644 --- a/src/app/admin/settings/tabs/LibraryTab/PlexSection.tsx +++ b/src/app/admin/settings/tabs/LibraryTab/PlexSection.tsx @@ -7,6 +7,7 @@ import { Input } from '@/components/ui/Input'; import { Button } from '@/components/ui/Button'; import { Settings, PlexLibrary } from '../../lib/types'; import { AUDIBLE_REGIONS } from '@/lib/types/audible'; +import { AudibleLanguageFilterOption } from './AudibleLanguageFilterOption'; interface PlexSectionProps { settings: Settings; @@ -199,6 +200,7 @@ export function PlexSection({ Select the Audible region that matches your metadata engine (Audnexus/Audible Agent) configuration in Plex. This ensures accurate book matching and metadata.

+
diff --git a/src/app/api/admin/settings/audible/route.ts b/src/app/api/admin/settings/audible/route.ts index ce964b9c3..8fe61609b 100644 --- a/src/app/api/admin/settings/audible/route.ts +++ b/src/app/api/admin/settings/audible/route.ts @@ -19,7 +19,7 @@ export async function PUT(request: NextRequest) { return requireAuth(request, async (req: AuthenticatedRequest) => { return requireAdmin(req, async () => { try { - const { region } = await request.json(); + const { region, languageFilter } = await request.json(); // Validate region if (!region || !VALID_REGIONS.includes(region)) { @@ -30,19 +30,38 @@ export async function PUT(request: NextRequest) { ); } + // Optional: omitting languageFilter keeps the stored value + if (languageFilter !== undefined && typeof languageFilter !== 'boolean') { + logger.warn('Invalid language filter provided', { languageFilter }); + return NextResponse.json( + { success: false, error: 'languageFilter must be a boolean' }, + { status: 400 } + ); + } + // Save region to configuration const configService = getConfigService(); - await configService.setMany([ + const updates = [ { key: 'audible.region', value: region, category: 'system', description: 'Audible region for metadata and search', }, - ]); + ]; + if (languageFilter !== undefined) { + updates.push({ + key: 'audible.language_filter', + value: String(languageFilter), + category: 'system', + description: "Hide books not in the region's language from search, BookDate and shelf sync", + }); + } + await configService.setMany(updates); - // Clear config cache to ensure new region is loaded immediately + // Clear config cache to ensure new values are loaded immediately configService.clearCache('audible.region'); + configService.clearCache('audible.language_filter'); // Force AudibleService to re-initialize with new region const audibleService = getAudibleService(); diff --git a/src/app/api/admin/settings/route.ts b/src/app/api/admin/settings/route.ts index 08163d284..3ccff2d5b 100644 --- a/src/app/api/admin/settings/route.ts +++ b/src/app/api/admin/settings/route.ts @@ -46,6 +46,7 @@ export async function GET(request: NextRequest) { hasLocalUsers, hasLocalAdmins, audibleRegion: configMap.get('audible.region') || 'us', + audibleLanguageFilter: configMap.get('audible.language_filter') === 'true', plex: { url: configMap.get('plex_url') || '', token: maskValue('token', configMap.get('plex_token')), diff --git a/src/app/api/audiobooks/search/route.ts b/src/app/api/audiobooks/search/route.ts index d61c70d14..9f4125360 100644 --- a/src/app/api/audiobooks/search/route.ts +++ b/src/app/api/audiobooks/search/route.ts @@ -35,7 +35,7 @@ export async function GET(request: NextRequest) { } const audibleService = getAudibleService(); - const results = await audibleService.search(query, page); + const results = await audibleService.search(query, page, { respectLanguageFilter: true }); // Get current user (optional — JWT or API token — for request-status enrichment) const currentUser = await getCurrentUserAsync(request); diff --git a/src/lib/bookdate/helpers.ts b/src/lib/bookdate/helpers.ts index 2a51e788f..3a32b2e37 100644 --- a/src/lib/bookdate/helpers.ts +++ b/src/lib/bookdate/helpers.ts @@ -922,7 +922,7 @@ export async function matchToAudnexus( logger.info(`Not in cache, searching Audible for "${title}" by ${author}...`); const audibleService = new AudibleService(); const searchQuery = `${title} ${author}`; - const searchResults = await audibleService.search(searchQuery, 1); + const searchResults = await audibleService.search(searchQuery, 1, { respectLanguageFilter: true }); if (!searchResults.results || searchResults.results.length === 0) { logger.warn(`No Audible search results for "${title}" by ${author}`); diff --git a/src/lib/integrations/audible.service.ts b/src/lib/integrations/audible.service.ts index 71529a2e9..7c58c1343 100644 --- a/src/lib/integrations/audible.service.ts +++ b/src/lib/integrations/audible.service.ts @@ -532,7 +532,16 @@ export class AudibleService { return audiobooks; } - async search(query: string, page: number = 1): Promise { + /** + * Keyword search on the catalog API, which returns every language. + * `respectLanguageFilter` applies the admin `audible.language_filter` setting + * (products with no language are kept). + */ + async search( + query: string, + page: number = 1, + options: { respectLanguageFilter?: boolean } = {}, + ): Promise { await this.initialize(); try { @@ -556,20 +565,33 @@ export class AudibleService { const products = envelope.products ?? []; const totalResults = envelope.total_results ?? 0; - const results = products.map(mapCatalogProduct); + const filterLanguage = + options.respectLanguageFilter && (await getConfigService().getAudibleLanguageFilter()); + const kept = filterLanguage + ? products.filter( + (p) => !p.language || isAcceptedLanguage(p.language, getLanguageForRegion(this.region)), + ) + : products; + const results = kept.map(mapCatalogProduct); - logger.info(` Found ${results.length} results for "${query}"`); + logger.info( + ` Found ${results.length} results for "${query}"` + + (kept.length < products.length + ? ` (${products.length - kept.length} in other languages hidden)` + : ''), + ); + // Paginate on the raw page: a page whose books were all filtered out is not the last one return { query, results, totalResults, page, hasMore: - results.length > 0 && + products.length > 0 && (totalResults > 0 ? totalResults > page * AUDIBLE_PAGE_SIZE - : results.length >= AUDIBLE_PAGE_SIZE), + : products.length >= AUDIBLE_PAGE_SIZE), }; } catch (error) { logger.error('Search failed', { diff --git a/src/lib/services/config.service.ts b/src/lib/services/config.service.ts index ae597cb5c..0d6c6c67f 100644 --- a/src/lib/services/config.service.ts +++ b/src/lib/services/config.service.ts @@ -237,6 +237,13 @@ export class ConfigurationService { return (region as AudibleRegion) || DEFAULT_AUDIBLE_REGION; } + /** + * Check if the Audible language filter is enabled + */ + async getAudibleLanguageFilter(): Promise { + return (await this.get('audible.language_filter')) === 'true'; + } + /** * Clear the cache for a specific key or all keys */ diff --git a/src/lib/services/shelf-sync-core.service.ts b/src/lib/services/shelf-sync-core.service.ts index ef496a394..bdc3e7fab 100644 --- a/src/lib/services/shelf-sync-core.service.ts +++ b/src/lib/services/shelf-sync-core.service.ts @@ -205,7 +205,7 @@ async function performAudibleLookup( const fullQuery = `${book.title} ${book.author}`; log.info(`Searching Audible for: "${fullQuery}"`); - let searchResult = await audibleService.search(fullQuery); + let searchResult = await audibleService.search(fullQuery, 1, { respectLanguageFilter: true }); let firstResult = searchResult.results[0]; if (!firstResult?.asin) { @@ -213,7 +213,7 @@ async function performAudibleLookup( if (cleanTitle !== book.title) { const cleanQuery = `${cleanTitle} ${book.author}`; log.info(`No results with full title, retrying without series info: "${cleanQuery}"`); - searchResult = await audibleService.search(cleanQuery); + searchResult = await audibleService.search(cleanQuery, 1, { respectLanguageFilter: true }); firstResult = searchResult.results[0]; } } diff --git a/tests/api/admin-settings-audible.routes.test.ts b/tests/api/admin-settings-audible.routes.test.ts new file mode 100644 index 000000000..361b46be9 --- /dev/null +++ b/tests/api/admin-settings-audible.routes.test.ts @@ -0,0 +1,94 @@ +/** + * Component: Admin Audible Settings API Route Tests + * Documentation: documentation/settings-pages.md + */ + +import { beforeEach, describe, expect, it, vi } from 'vitest'; + +let authRequest: any; + +const requireAuthMock = vi.hoisted(() => vi.fn()); +const requireAdminMock = vi.hoisted(() => vi.fn()); +const configServiceMock = vi.hoisted(() => ({ + setMany: vi.fn(), + clearCache: vi.fn(), +})); +const audibleServiceMock = vi.hoisted(() => ({ + forceReinitialize: vi.fn(), +})); +const jobQueueMock = vi.hoisted(() => ({ + addAudibleRefreshJob: vi.fn(), +})); + +vi.mock('@/lib/middleware/auth', () => ({ + requireAuth: requireAuthMock, + requireAdmin: requireAdminMock, +})); + +vi.mock('@/lib/services/config.service', () => ({ + getConfigService: () => configServiceMock, +})); + +vi.mock('@/lib/integrations/audible.service', () => ({ + getAudibleService: () => audibleServiceMock, +})); + +vi.mock('@/lib/services/job-queue.service', () => ({ + getJobQueueService: () => jobQueueMock, +})); + +describe('Admin Audible settings route', () => { + beforeEach(() => { + vi.clearAllMocks(); + authRequest = { user: { id: 'admin-1', role: 'admin' }, json: vi.fn() }; + requireAuthMock.mockImplementation((_req: any, handler: any) => handler(authRequest)); + requireAdminMock.mockImplementation((_req: any, handler: any) => handler()); + }); + + it('updates Audible region and triggers refresh', async () => { + const request = { json: vi.fn().mockResolvedValue({ region: 'us' }) }; + + const { PUT } = await import('@/app/api/admin/settings/audible/route'); + const response = await PUT(request as any); + const payload = await response.json(); + + expect(payload.success).toBe(true); + expect(jobQueueMock.addAudibleRefreshJob).toHaveBeenCalled(); + }); + + it('saves the Audible language filter with the region', async () => { + const request = { json: vi.fn().mockResolvedValue({ region: 'fr', languageFilter: true }) }; + + const { PUT } = await import('@/app/api/admin/settings/audible/route'); + const response = await PUT(request as any); + + expect(response.status).toBe(200); + expect(configServiceMock.setMany).toHaveBeenCalledWith( + expect.arrayContaining([ + expect.objectContaining({ key: 'audible.region', value: 'fr' }), + expect.objectContaining({ key: 'audible.language_filter', value: 'true' }), + ]), + ); + expect(configServiceMock.clearCache).toHaveBeenCalledWith('audible.language_filter'); + }); + + it('leaves the Audible language filter untouched when only the region is sent', async () => { + const request = { json: vi.fn().mockResolvedValue({ region: 'us' }) }; + + const { PUT } = await import('@/app/api/admin/settings/audible/route'); + await PUT(request as any); + + const updates = configServiceMock.setMany.mock.calls[0][0]; + expect(updates.map((u: { key: string }) => u.key)).toEqual(['audible.region']); + }); + + it('rejects a non-boolean Audible language filter', async () => { + const request = { json: vi.fn().mockResolvedValue({ region: 'fr', languageFilter: 'yes' }) }; + + const { PUT } = await import('@/app/api/admin/settings/audible/route'); + const response = await PUT(request as any); + + expect(response.status).toBe(400); + expect(configServiceMock.setMany).not.toHaveBeenCalled(); + }); +}); diff --git a/tests/api/admin-settings-core.routes.test.ts b/tests/api/admin-settings-core.routes.test.ts index 7c8d391cb..c6e807406 100644 --- a/tests/api/admin-settings-core.routes.test.ts +++ b/tests/api/admin-settings-core.routes.test.ts @@ -100,6 +100,7 @@ describe('Admin settings core routes', () => { { key: 'plex_url', value: 'http://plex' }, { key: 'plex_token', value: 'token' }, { key: 'system.backend_mode', value: 'plex' }, + { key: 'audible.language_filter', value: 'true' }, ]); prismaMock.user.count.mockResolvedValueOnce(0); @@ -109,6 +110,7 @@ describe('Admin settings core routes', () => { expect(payload.plex.url).toBe('http://plex'); expect(payload.backendMode).toBe('plex'); + expect(payload.audibleLanguageFilter).toBe(true); }); it('updates Plex settings', async () => { @@ -366,17 +368,6 @@ describe('Admin settings core routes', () => { expect(configServiceMock.setMany).toHaveBeenCalled(); }); - it('updates Audible region and triggers refresh', async () => { - const request = { json: vi.fn().mockResolvedValue({ region: 'us' }) }; - - const { PUT } = await import('@/app/api/admin/settings/audible/route'); - const response = await PUT(request as any); - const payload = await response.json(); - - expect(payload.success).toBe(true); - expect(jobQueueMock.addAudibleRefreshJob).toHaveBeenCalled(); - }); - it('updates Audiobookshelf settings', async () => { const request = { json: vi.fn().mockResolvedValue({ diff --git a/tests/api/audiobooks-browse.routes.test.ts b/tests/api/audiobooks-browse.routes.test.ts index b162db12e..2d5ff3f5b 100644 --- a/tests/api/audiobooks-browse.routes.test.ts +++ b/tests/api/audiobooks-browse.routes.test.ts @@ -62,6 +62,7 @@ describe('Audiobooks browse routes', () => { const payload = await response.json(); expect(payload.success).toBe(true); + expect(audibleServiceMock.search).toHaveBeenCalledWith('query', 1, { respectLanguageFilter: true }); expect(enrichMock).toHaveBeenCalledWith([{ asin: 'ASIN', title: 'Title', author: 'Author' }], 'user-1'); }); diff --git a/tests/app/admin-settings.page.test.tsx b/tests/app/admin-settings.page.test.tsx index 4e8e3ee9b..160634c1e 100644 --- a/tests/app/admin-settings.page.test.tsx +++ b/tests/app/admin-settings.page.test.tsx @@ -73,6 +73,7 @@ const settingsFixture = { backendMode: 'plex', hasLocalUsers: true, audibleRegion: 'us', + audibleLanguageFilter: false, plex: { url: '', token: '', libraryId: '', triggerScanAfterImport: false }, audiobookshelf: { serverUrl: '', apiToken: '', libraryId: '', triggerScanAfterImport: false }, oidc: { diff --git a/tests/app/admin/settings/hooks/useSettings.test.tsx b/tests/app/admin/settings/hooks/useSettings.test.tsx index 8824a5c47..9121873e7 100644 --- a/tests/app/admin/settings/hooks/useSettings.test.tsx +++ b/tests/app/admin/settings/hooks/useSettings.test.tsx @@ -29,6 +29,7 @@ const baseSettings = { backendMode: 'plex', hasLocalUsers: true, audibleRegion: 'us', + audibleLanguageFilter: false, plex: { url: '', token: '', libraryId: '', triggerScanAfterImport: false }, audiobookshelf: { serverUrl: '', apiToken: '', libraryId: '', triggerScanAfterImport: false }, oidc: { diff --git a/tests/app/admin/settings/lib/helpers.test.ts b/tests/app/admin/settings/lib/helpers.test.ts index b9e53a5b1..e8d53b009 100644 --- a/tests/app/admin/settings/lib/helpers.test.ts +++ b/tests/app/admin/settings/lib/helpers.test.ts @@ -21,6 +21,7 @@ const baseSettings = { hasLocalUsers: true, hasLocalAdmins: true, audibleRegion: 'us', + audibleLanguageFilter: false, plex: { url: 'http://plex', token: 'token', libraryId: 'lib', triggerScanAfterImport: false }, audiobookshelf: { serverUrl: 'http://abs', apiToken: 'abs-token', libraryId: 'abs-lib', triggerScanAfterImport: false }, oidc: { @@ -217,7 +218,10 @@ describe('admin settings helpers', () => { expect(fetchWithAuthMock).toHaveBeenCalledWith( '/api/admin/settings/audible', - expect.objectContaining({ method: 'PUT' }) + expect.objectContaining({ + method: 'PUT', + body: JSON.stringify({ region: 'us', languageFilter: false }), + }) ); expect(fetchWithAuthMock).toHaveBeenCalledWith( '/api/admin/settings/plex', diff --git a/tests/app/admin/settings/tabs/LibraryTab/AudibleLanguageFilterOption.test.tsx b/tests/app/admin/settings/tabs/LibraryTab/AudibleLanguageFilterOption.test.tsx new file mode 100644 index 000000000..fd96abf47 --- /dev/null +++ b/tests/app/admin/settings/tabs/LibraryTab/AudibleLanguageFilterOption.test.tsx @@ -0,0 +1,27 @@ +/** + * Component: Audible Language Filter Option Tests + * Documentation: documentation/settings-pages.md + */ + +// @vitest-environment jsdom + +import { describe, expect, it, vi } from 'vitest'; +import { fireEvent, render, screen } from '@testing-library/react'; +import { AudibleLanguageFilterOption } from '@/app/admin/settings/tabs/LibraryTab/AudibleLanguageFilterOption'; +import type { Settings } from '@/app/admin/settings/lib/types'; + +describe('AudibleLanguageFilterOption', () => { + it('reflects the setting and reports the toggled value', () => { + const onChange = vi.fn(); + const settings = { audibleLanguageFilter: false } as Settings; + + render(); + + const checkbox = screen.getByRole('checkbox', { name: /region's language/i }); + expect(checkbox).not.toBeChecked(); + + fireEvent.click(checkbox); + + expect(onChange).toHaveBeenCalledWith({ audibleLanguageFilter: true }); + }); +}); diff --git a/tests/bookdate/helpers.test.ts b/tests/bookdate/helpers.test.ts index 5a9806f33..33ae6261e 100644 --- a/tests/bookdate/helpers.test.ts +++ b/tests/bookdate/helpers.test.ts @@ -822,7 +822,9 @@ describe('BookDate helpers', () => { const result = await matchToAudnexus('Missing', 'Author'); expect(result).toBeNull(); - expect(audibleState.instance.search).toHaveBeenCalled(); + expect(audibleState.instance.search).toHaveBeenCalledWith('Missing Author', 1, { + respectLanguageFilter: true, + }); }); it('returns null when Audible details are unavailable', async () => { diff --git a/tests/components/admin-settings-indexers.test.tsx b/tests/components/admin-settings-indexers.test.tsx index 98004c46e..54754243d 100644 --- a/tests/components/admin-settings-indexers.test.tsx +++ b/tests/components/admin-settings-indexers.test.tsx @@ -61,6 +61,7 @@ describe('IndexersTab - Auto-load Indexers on Tab Activation', () => { backendMode: 'plex', hasLocalUsers: false, audibleRegion: 'us', + audibleLanguageFilter: false, plex: { url: 'http://plex.local:32400', token: 'test-token', diff --git a/tests/integrations/audible.service.test.ts b/tests/integrations/audible.service.test.ts index ea4d955c9..a47d1c0a8 100644 --- a/tests/integrations/audible.service.test.ts +++ b/tests/integrations/audible.service.test.ts @@ -23,6 +23,7 @@ const axiosMock = vi.hoisted(() => ({ const configServiceMock = vi.hoisted(() => ({ getAudibleRegion: vi.fn(), + getAudibleLanguageFilter: vi.fn(), })); vi.mock('axios', () => ({ @@ -210,6 +211,7 @@ describe('AudibleService', () => { apiClientMock.get.mockReset(); axiosMock.get.mockReset(); configServiceMock.getAudibleRegion.mockReset(); + configServiceMock.getAudibleLanguageFilter.mockReset(); // Default: first create() → htmlClient, second → apiClient. axiosMock.create @@ -217,6 +219,7 @@ describe('AudibleService', () => { .mockReturnValueOnce(apiClientMock); configServiceMock.getAudibleRegion.mockResolvedValue('us'); + configServiceMock.getAudibleLanguageFilter.mockResolvedValue(false); }); // ------------------------------------------------------------------------- @@ -434,6 +437,62 @@ describe('AudibleService', () => { expect(apiClientMock.get).toHaveBeenCalled(); expect(htmlClientMock.get).not.toHaveBeenCalled(); }); + + describe('language filter', () => { + const mixedLanguages = () => [ + makeProduct({ asin: 'BFR0000001', language: 'french' }), + makeProduct({ asin: 'BEN0000001', language: 'english' }), + makeProduct({ asin: 'BES0000001', language: 'spanish' }), + makeProduct({ asin: 'BNO0000001', language: undefined }), + ]; + + beforeEach(() => { + configServiceMock.getAudibleRegion.mockResolvedValue('fr'); + }); + + it('hides other-language products when the caller opts in and the setting is on', async () => { + configServiceMock.getAudibleLanguageFilter.mockResolvedValue(true); + apiClientMock.get.mockResolvedValue(apiResponse(makeProductsResponse(mixedLanguages()))); + + const service = new AudibleService(); + const result = await service.search('test', 1, { respectLanguageFilter: true }); + + expect(result.results.map((b) => b.asin)).toEqual(['BFR0000001', 'BNO0000001']); + }); + + it('keeps every product when the setting is off', async () => { + apiClientMock.get.mockResolvedValue(apiResponse(makeProductsResponse(mixedLanguages()))); + + const service = new AudibleService(); + const result = await service.search('test', 1, { respectLanguageFilter: true }); + + expect(result.results).toHaveLength(4); + }); + + it('ignores the setting when the caller does not opt in', async () => { + configServiceMock.getAudibleLanguageFilter.mockResolvedValue(true); + apiClientMock.get.mockResolvedValue(apiResponse(makeProductsResponse(mixedLanguages()))); + + const service = new AudibleService(); + const result = await service.search('test', 1); + + expect(result.results).toHaveLength(4); + }); + + it('keeps paginating when every book on the page was filtered out', async () => { + configServiceMock.getAudibleLanguageFilter.mockResolvedValue(true); + const englishPage = Array.from({ length: 50 }, (_, i) => + makeProduct({ asin: `B${String(i).padStart(9, '0')}`, language: 'english' }), + ); + apiClientMock.get.mockResolvedValue(apiResponse(makeProductsResponse(englishPage, 150))); + + const service = new AudibleService(); + const result = await service.search('test', 1, { respectLanguageFilter: true }); + + expect(result.results).toEqual([]); + expect(result.hasMore).toBe(true); + }); + }); }); // ------------------------------------------------------------------------- diff --git a/tests/services/shelf-sync-core.service.test.ts b/tests/services/shelf-sync-core.service.test.ts new file mode 100644 index 000000000..3277f9c69 --- /dev/null +++ b/tests/services/shelf-sync-core.service.test.ts @@ -0,0 +1,57 @@ +/** + * Component: Shelf Sync Core Service Tests + * Documentation: documentation/backend/services/goodreads-sync.md + */ + +import { beforeEach, describe, expect, it, vi } from 'vitest'; +import { createPrismaMock } from '../helpers/prisma'; + +const prismaMock = createPrismaMock(); +const audibleServiceMock = vi.hoisted(() => ({ search: vi.fn() })); +const createRequestMock = vi.hoisted(() => vi.fn()); + +vi.mock('@/lib/db', () => ({ + prisma: prismaMock, +})); + +vi.mock('@/lib/integrations/audible.service', () => ({ + getAudibleService: () => audibleServiceMock, +})); + +vi.mock('@/lib/services/request-creator.service', () => ({ + createRequestForUser: createRequestMock, +})); + +const log = { info: vi.fn(), warn: vi.fn(), error: vi.fn() } as any; + +describe('processShelfBooks', () => { + beforeEach(() => { + vi.clearAllMocks(); + prismaMock.bookMapping.findUnique.mockResolvedValue(null); + prismaMock.bookMapping.findMany.mockResolvedValue([]); + prismaMock.audibleCache.findMany.mockResolvedValue([]); + }); + + it('applies the Audible language filter to lookups and records a miss as noMatch', async () => { + audibleServiceMock.search.mockResolvedValue({ results: [] }); + + const { processShelfBooks, createEmptyStats } = await import('@/lib/services/shelf-sync-core.service'); + await processShelfBooks( + 'goodreads', + [{ bookId: 'gr-1', title: 'Six of Crows', author: 'Leigh Bardugo' }], + 'user-1', + 'shelf-1', + createEmptyStats(), + log, + 10, + ); + + expect(audibleServiceMock.search).toHaveBeenCalledWith('Six of Crows Leigh Bardugo', 1, { + respectLanguageFilter: true, + }); + expect(prismaMock.bookMapping.create).toHaveBeenCalledWith({ + data: expect.objectContaining({ externalBookId: 'gr-1', noMatch: true, audibleAsin: null }), + }); + expect(createRequestMock).not.toHaveBeenCalled(); + }); +});