Repository navigation
build: run skills lint after Prettier in pre-commit - #460
Merged
Merged
Conversation
The owner migration commands wrote their snapshots under a directory named after a tracking ticket. Name it after what it holds instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G8Kd268BopJxWoW8pPYq7T
lint-staged runs separate config entries concurrently, and every skill input also matches the entry that runs `prettier --write` on non-code files, so `pnpm lint:skills` could read a skill while Prettier was rewriting it. Run the skills lint from that entry instead, after Prettier, and only when a staged file is a skill input. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G8Kd268BopJxWoW8pPYq7T
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cva | 5538235 | Commit Preview URL Branch Preview URL |
Oct 05 2026, 06:34 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Joe · project thread
Description
Before: lint-staged ran
pnpm lint:skillsas its own entry, alongside the Prettier entry. When a skill file was staged, the lint could read it while Prettier was still rewriting it.After:
lint:skillsruns inside the non-code Prettier entry, afterprettier --write, and only when a skill input (skills/**,.agents/skills/**orskill-check.config.json) is staged. Other files get Prettier only. AGENTS.md describes the new order.This also renames the snapshot directory in
.github/rulesets/README.mdto/tmp/cva-default-branch.Additional context
lint-staged runs the commands in one entry in sequence, so the race can no longer happen. The change assumes skill inputs are non-code files, which is true today; the config comment says so.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).🤖 Generated with Claude Code
https://claude.ai/code/session_01G8Kd268BopJxWoW8pPYq7T
Generated by Claude Code