Why is ClassProp in VariantProps?

[hasparus]

Howdy 👋

I'm using cva with React, and I'm declaring my props like this.

const buttonStyle = cva("...", {
  variants: {
    intent: { primary: "..." }
  }
});

export interface ButtonProps
  extends React.ComponentPropsWithoutRef<"button">,
    Omit<VariantProps<typeof buttonStyle>, "class"> {}
    
export function Button({ className, intent, ...rest }: ButtonProps) {
  return <button className={buttonStyle({ class: className, intent })} {...rest} />;
}

VariantProps includes ClassProp { class?: ClassValue }.

I already have className. I'd rather avoid having a class prop too, so I'm using Omit to remove it.

It's not a big issue, but I wanted to ask if you considered a version of VariantProps type without the class.

Thank you and KUTGW :)

[joe-bell]

Good question! I'd be up for removing it 🕺

[joe-bell]

Forgot to mention this was fixed in 0.2.3