From b5ccdd49910cb8a6490dbcac681be09c1affe0a0 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 18:38:47 -0400
Subject: [PATCH 1/6] Extract event handlers in

---
 .../BuildPipelineView/bpp-trigger-pipeline.js   | 17 +++++++++++++++++
 .../buildpipeline/BuildPipelineView/bpp.jelly   |  6 ++++--
 2 files changed, 21 insertions(+), 2 deletions(-)
 create mode 100644 src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
new file mode 100644
index 00000000..033c3eb3
--- /dev/null
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
@@ -0,0 +1,17 @@
+Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.TriggerPipelineParameterized', 0, function(element) {
+    element.addEventListener('click', function() {
+
+        const paramsElement = element.previousElementSibling;
+        const href = paramsElement.dataset.fillDialogHref;
+        const title = paramsElement.dataset.fillDialogTitle;
+
+        buildPipeline.fillDialog(href, title);
+
+    });
+});
+
+Behaviour.specify(".bpp-trigger-pipeline-button", 'BuildPipelineView.TriggerPipeline', 0, function(element) {
+    element.addEventListener('click', function(e) {
+        document.getElementById('triggerPipelineForm').submit();
+    });
+});
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
index f349bfc8..6198d6ad 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -12,6 +12,7 @@
     </j:if>
 
     <st:adjunct includes="io.jenkins.plugins.jquery3"/>
+    <st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.BuildPipelineView.bpp-trigger-pipeline"/>
     <script src="${rootURL}/plugin/build-pipeline-plugin/js/jquery-migrate-1.2.1.min.js"></script>
     <script type="text/javascript" src="${rootURL}/plugin/build-pipeline-plugin/js/jquery-ui-1.8.14.custom.min.js"></script>
     <script type="text/javascript" src="${rootURL}/plugin/build-pipeline-plugin/js/handlebars-1.0.0.beta.6.js"></script>
@@ -62,13 +63,14 @@
         <j:if test="${hasBuildPermission}">
             <div class="icon-container">
             <j:if test="${from.isProjectParameterized()}">
-                <span class="pointer" onclick="buildPipeline.fillDialog('${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec', 'Starts the pipeline with parameters')">
+                <span class="bpp-trigger-pipeline-parameterized-params" data-fill-dialog-href="${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec" data-fill-dialog-title="Starts the pipeline with parameters" style="display: none" />
+                <span class="bpp-trigger-pipeline-parameterized pointer">
                     <l:icon src="icon-clock icon-md" alt="Trigger a Pipeline" />
                                 <span>Run</span>
                 </span>
             </j:if>
             <j:if test="${!from.isProjectParameterized()}">
-              <a id="trigger-pipeline-button" href='#' onclick="document.getElementById('triggerPipelineForm').submit()">
+              <a class="bpp-trigger-pipeline-button" id="trigger-pipeline-button" href='#'>
                 <l:icon src="icon-clock icon-md" alt="Trigger a Pipeline" />
                                 <span>Run</span>
               </a>

From 85dcb4bf1260334b2fdcc6903f1add5be3630bb6 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 18:47:13 -0400
Subject: [PATCH 2/6] Extract event handlers in

---
 .../buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js    | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
index 033c3eb3..4bee5d4f 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
@@ -1,12 +1,9 @@
 Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.TriggerPipelineParameterized', 0, function(element) {
     element.addEventListener('click', function() {
-
         const paramsElement = element.previousElementSibling;
         const href = paramsElement.dataset.fillDialogHref;
         const title = paramsElement.dataset.fillDialogTitle;
-
         buildPipeline.fillDialog(href, title);
-
     });
 });
 

From e40e43bedb64dc393edae4373151a12eddad4cc9 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Wed, 30 Oct 2024 18:54:59 -0400
Subject: [PATCH 3/6] Extract event handlers in

---
 .../buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
index 4bee5d4f..5fc5c577 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
@@ -1,6 +1,6 @@
 Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.TriggerPipelineParameterized', 0, function(element) {
     element.addEventListener('click', function() {
-        const paramsElement = element.previousElementSibling;
+        const paramsElement = document.querySelector('.bpp-trigger-pipeline-parameterized-params');
         const href = paramsElement.dataset.fillDialogHref;
         const title = paramsElement.dataset.fillDialogTitle;
         buildPipeline.fillDialog(href, title);

From bacdf4979b99084e6e8c73bbd94437e6830587e9 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Fri, 8 Nov 2024 12:40:12 -0500
Subject: [PATCH 4/6] remove redundant class

---
 .../buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js     | 2 +-
 .../hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
index 5fc5c577..97580dab 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
@@ -7,7 +7,7 @@ Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.Trig
     });
 });
 
-Behaviour.specify(".bpp-trigger-pipeline-button", 'BuildPipelineView.TriggerPipeline', 0, function(element) {
+Behaviour.specify("#trigger-pipeline-button", 'BuildPipelineView.TriggerPipeline', 0, function(element) {
     element.addEventListener('click', function(e) {
         document.getElementById('triggerPipelineForm').submit();
     });
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
index 6198d6ad..3e5a7479 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -70,7 +70,7 @@
                 </span>
             </j:if>
             <j:if test="${!from.isProjectParameterized()}">
-              <a class="bpp-trigger-pipeline-button" id="trigger-pipeline-button" href='#'>
+              <a id="trigger-pipeline-button" href='#'>
                 <l:icon src="icon-clock icon-md" alt="Trigger a Pipeline" />
                                 <span>Run</span>
               </a>

From cfae875a09d00e0eca79747ca3853f865bd066c0 Mon Sep 17 00:00:00 2001
From: shlomomdahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Fri, 8 Nov 2024 15:45:26 -0500
Subject: [PATCH 5/6] remove redundant span, add attributes to trigger span

---
 .../buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js  | 5 ++---
 .../hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly  | 3 +--
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
index 97580dab..16dbaa11 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
@@ -1,8 +1,7 @@
 Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.TriggerPipelineParameterized', 0, function(element) {
     element.addEventListener('click', function() {
-        const paramsElement = document.querySelector('.bpp-trigger-pipeline-parameterized-params');
-        const href = paramsElement.dataset.fillDialogHref;
-        const title = paramsElement.dataset.fillDialogTitle;
+        const href = element.dataset.fillDialogHref;
+        const title = element.dataset.fillDialogTitle;
         buildPipeline.fillDialog(href, title);
     });
 });
diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
index 3e5a7479..6ab50783 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
@@ -63,8 +63,7 @@
         <j:if test="${hasBuildPermission}">
             <div class="icon-container">
             <j:if test="${from.isProjectParameterized()}">
-                <span class="bpp-trigger-pipeline-parameterized-params" data-fill-dialog-href="${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec" data-fill-dialog-title="Starts the pipeline with parameters" style="display: none" />
-                <span class="bpp-trigger-pipeline-parameterized pointer">
+                <span class="bpp-trigger-pipeline-parameterized pointer" data-fill-dialog-href="${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec" data-fill-dialog-title="Starts the pipeline with parameters">
                     <l:icon src="icon-clock icon-md" alt="Trigger a Pipeline" />
                                 <span>Run</span>
                 </span>

From 76a622796b14ad8f8ee9b7966cdca6f8fd61cab9 Mon Sep 17 00:00:00 2001
From: Shlomo Dahan <64103471+shlomomdahan@users.noreply.github.com>
Date: Tue, 12 Nov 2024 13:38:41 -0500
Subject: [PATCH 6/6] Update
 src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js

Co-authored-by: Yaroslav <91559310+yaroslavafenkin@users.noreply.github.com>
---
 .../buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
index 16dbaa11..6559e487 100644
--- a/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
+++ b/src/main/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
@@ -7,7 +7,7 @@ Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.Trig
 });
 
 Behaviour.specify("#trigger-pipeline-button", 'BuildPipelineView.TriggerPipeline', 0, function(element) {
-    element.addEventListener('click', function(e) {
+    element.addEventListener('click', function() {
         document.getElementById('triggerPipelineForm').submit();
     });
 });