From 5e5cf2f858aec08af541178e0bb8b17cbcf9110d Mon Sep 17 00:00:00 2001 From: Scott Hart Date: Mon, 31 Aug 2026 19:47:58 -0400 Subject: [PATCH 1/2] chore(storage): reduce deprecation warnings from tests --- .../storage/internal/async/writer_connection_impl_test.cc | 3 +++ google/cloud/storage/internal/checksum_helpers_test.cc | 3 +++ google/cloud/storage/internal/object_requests_test.cc | 5 +++-- google/cloud/storage/internal/signed_url_requests_test.cc | 3 +++ 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/google/cloud/storage/internal/async/writer_connection_impl_test.cc b/google/cloud/storage/internal/async/writer_connection_impl_test.cc index 7d5c40a902a10..b4cc8735e3223 100644 --- a/google/cloud/storage/internal/async/writer_connection_impl_test.cc +++ b/google/cloud/storage/internal/async/writer_connection_impl_test.cc @@ -12,6 +12,9 @@ // See the License for the specific language governing permissions and // limitations under the License. +// TODO(#16404): Remove deprecation disable include. +#include "google/cloud/internal/disable_deprecation_warnings.inc" + #include "google/cloud/storage/internal/async/writer_connection_impl.h" #include "google/cloud/mocks/mock_async_streaming_read_write_rpc.h" #include "google/cloud/storage/async/options.h" diff --git a/google/cloud/storage/internal/checksum_helpers_test.cc b/google/cloud/storage/internal/checksum_helpers_test.cc index 8cdfea963674e..a4344c164a499 100644 --- a/google/cloud/storage/internal/checksum_helpers_test.cc +++ b/google/cloud/storage/internal/checksum_helpers_test.cc @@ -12,6 +12,9 @@ // See the License for the specific language governing permissions and // limitations under the License. +// TODO(#16404): Remove deprecation disable include. +#include "google/cloud/internal/disable_deprecation_warnings.inc" + #include "google/cloud/storage/internal/checksum_helpers.h" #include "google/cloud/storage/internal/object_requests.h" #include diff --git a/google/cloud/storage/internal/object_requests_test.cc b/google/cloud/storage/internal/object_requests_test.cc index e9cbe0a85e7d0..c827b6468868e 100644 --- a/google/cloud/storage/internal/object_requests_test.cc +++ b/google/cloud/storage/internal/object_requests_test.cc @@ -12,6 +12,9 @@ // See the License for the specific language governing permissions and // limitations under the License. +// TODO(#16404): Remove deprecation disable include. +#include "google/cloud/internal/disable_deprecation_warnings.inc" + #include "google/cloud/storage/internal/object_requests.h" #include "google/cloud/storage/internal/object_access_control_parser.h" #include "google/cloud/storage/internal/object_acl_requests.h" @@ -189,7 +192,6 @@ TEST(ObjectRequestsTest, InsertObjectMediaUpdateContents) { EXPECT_EQ("new contents", request.payload()); } -#include "google/cloud/internal/disable_deprecation_warnings.inc" TEST(ObjectRequestsTest, InsertObjectBackwardsCompat) { auto const payload = std::string("The quick brown fox jumps over the lazy dog"); @@ -201,7 +203,6 @@ TEST(ObjectRequestsTest, InsertObjectBackwardsCompat) { EXPECT_EQ(zebras, request.payload()); EXPECT_EQ(zebras, request.contents()); } -#include "google/cloud/internal/diagnostics_pop.inc" TEST(ObjectRequestsTest, Copy) { CopyObjectRequest request("source-bucket", "source-object", "my-bucket", diff --git a/google/cloud/storage/internal/signed_url_requests_test.cc b/google/cloud/storage/internal/signed_url_requests_test.cc index 82374c50cdc3b..195300899f260 100644 --- a/google/cloud/storage/internal/signed_url_requests_test.cc +++ b/google/cloud/storage/internal/signed_url_requests_test.cc @@ -12,6 +12,9 @@ // See the License for the specific language governing permissions and // limitations under the License. +// TODO(#16404): Remove deprecation disable include. +#include "google/cloud/internal/disable_deprecation_warnings.inc" + #include "google/cloud/storage/internal/signed_url_requests.h" #include "google/cloud/internal/format_time_point.h" #include "google/cloud/internal/parse_rfc3339.h" From e6cf5c1f8fdadd7406857873e7e189d96a7f0ff4 Mon Sep 17 00:00:00 2001 From: Scott Hart Date: Tue, 1 Sep 2026 12:18:30 -0400 Subject: [PATCH 2/2] formatting --- .../cloud/storage/internal/async/writer_connection_impl_test.cc | 1 - google/cloud/storage/internal/checksum_helpers_test.cc | 1 - google/cloud/storage/internal/object_requests_test.cc | 1 - google/cloud/storage/internal/signed_url_requests_test.cc | 1 - 4 files changed, 4 deletions(-) diff --git a/google/cloud/storage/internal/async/writer_connection_impl_test.cc b/google/cloud/storage/internal/async/writer_connection_impl_test.cc index b4cc8735e3223..ebf2df07e2181 100644 --- a/google/cloud/storage/internal/async/writer_connection_impl_test.cc +++ b/google/cloud/storage/internal/async/writer_connection_impl_test.cc @@ -14,7 +14,6 @@ // TODO(#16404): Remove deprecation disable include. #include "google/cloud/internal/disable_deprecation_warnings.inc" - #include "google/cloud/storage/internal/async/writer_connection_impl.h" #include "google/cloud/mocks/mock_async_streaming_read_write_rpc.h" #include "google/cloud/storage/async/options.h" diff --git a/google/cloud/storage/internal/checksum_helpers_test.cc b/google/cloud/storage/internal/checksum_helpers_test.cc index a4344c164a499..7a0394ba5e1c9 100644 --- a/google/cloud/storage/internal/checksum_helpers_test.cc +++ b/google/cloud/storage/internal/checksum_helpers_test.cc @@ -14,7 +14,6 @@ // TODO(#16404): Remove deprecation disable include. #include "google/cloud/internal/disable_deprecation_warnings.inc" - #include "google/cloud/storage/internal/checksum_helpers.h" #include "google/cloud/storage/internal/object_requests.h" #include diff --git a/google/cloud/storage/internal/object_requests_test.cc b/google/cloud/storage/internal/object_requests_test.cc index c827b6468868e..1d45967ba28a3 100644 --- a/google/cloud/storage/internal/object_requests_test.cc +++ b/google/cloud/storage/internal/object_requests_test.cc @@ -14,7 +14,6 @@ // TODO(#16404): Remove deprecation disable include. #include "google/cloud/internal/disable_deprecation_warnings.inc" - #include "google/cloud/storage/internal/object_requests.h" #include "google/cloud/storage/internal/object_access_control_parser.h" #include "google/cloud/storage/internal/object_acl_requests.h" diff --git a/google/cloud/storage/internal/signed_url_requests_test.cc b/google/cloud/storage/internal/signed_url_requests_test.cc index 195300899f260..283cdf77800de 100644 --- a/google/cloud/storage/internal/signed_url_requests_test.cc +++ b/google/cloud/storage/internal/signed_url_requests_test.cc @@ -14,7 +14,6 @@ // TODO(#16404): Remove deprecation disable include. #include "google/cloud/internal/disable_deprecation_warnings.inc" - #include "google/cloud/storage/internal/signed_url_requests.h" #include "google/cloud/internal/format_time_point.h" #include "google/cloud/internal/parse_rfc3339.h"