Repository navigation
docs: fix upload-to-stitch path so it works outside a repo checkout (#96) - #110
Open
Sahilkumar-r wants to merge 1 commit into
Open
Sahilkumar-r wants to merge 1 commit into
Sahilkumar-r wants to merge 1 commit into
Conversation
…oogle-labs-code#96) manage-design-system told the agent to run stitch-skills/plugins/stitch-design/skills/upload-to-stitch/scripts/upload_to_stitch.py, a path that only resolves inside a git clone of this repo. When the plugin is installed through the marketplace, the script instead lives under ${CLAUDE_PLUGIN_ROOT}/skills/upload-to-stitch/scripts/, so the command failed from any project cwd. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#96:
manage-design-system/SKILL.md(step "Upload DESIGN.md", Option A) tells the agent to runThat path is only valid relative to a git clone of this repository. When the
stitch-designplugin is installed through the marketplace, the script lives at${CLAUDE_PLUGIN_ROOT}/skills/upload-to-stitch/scripts/upload_to_stitch.pyinstead, so the command fails from any project cwd.Fix
Swapped the hard-coded repo-relative path for
${CLAUDE_PLUGIN_ROOT}/skills/upload-to-stitch/scripts/upload_to_stitch.py, exactly as the issue suggested.plugins/stitch-design/plugin.jsonconfirmsplugins/stitch-design/is the directory${CLAUDE_PLUGIN_ROOT}resolves to for this plugin, under whichskills/upload-to-stitch/scripts/upload_to_stitch.pyalready exists — so the new path is correct both inside a repo checkout and in a real marketplace install.Verification
Doc-only fix (a path string inside a markdown instruction block); there's no code to unit-test.
.github/workflows/validate-skills.ymldoesn't cover this file. Verified by inspectingplugin.json/the marketplace manifest to confirm the resolved path is correct, and that no other skill in the repo already relies on the old hard-coded path (only this one line referenced it).Note: per
CONTRIBUTING.md, this will need a signed Google CLA (cla.developers.google.com) from the account owner before it can merge — that'll be handled separately.🤖 Generated with Claude Code