From b94c12dcca02bb72f3ee52bdf4ec37ac09c44974 Mon Sep 17 00:00:00 2001
From: Claude <david@flipmine.com>
Date: Mon, 22 Jun 2026 01:36:40 +0000
Subject: [PATCH] Fix v0.1.3 regression: stop coercing stored string values

v0.1.3 changed Vivification#vivify_value from a class-based case/when
into a pattern-matching case/in that ran every stored value through
INTEGER/FLOAT/DATELIKE regexes. Because vivify_value runs on every
construction (#initialize -> #vivify) and every assignment (#[]=), this
silently corrupted any string containing a digit:

  Flexor.new(address: "123 Main Street").address # => 123
  Flexor.new(note: "call me at 3pm").note         # => 0.0
  Flexor.new(ts: "2023-01-15T10:30:00").ts        # => 2023

The branch was also internally broken (the DATELIKE arm does
`require "datetime"`, which does not exist, and calls `it` outside a
block), but INTEGER matched date strings first so that arm was dead.

No spec caught this because every string value in the suite is
digit-free ("alice", "deep", "localhost", ...) and every digit-bearing
datum is either already an Integer or nested inside an Array (which
goes through the untouched vivify_array path).

Restore vivify_value to pass non-Hash/Array values through unchanged,
add regression coverage for construction and assignment of
number-/date-like strings, and remove the stray root-level
patterns_spec.rb left over from the abandoned coercion experiment.

Bump version to 0.1.4

Release the v0.1.3 regression fix (string values were silently coerced
to Integer/Float on every store). 0.1.3 should be considered broken.

Add leading-zero and currency cases to coercion regression specs

Broaden the v0.1.3 regression coverage with two more real-world strings
the coercion destroyed: a leading-zero ZIP ("01970" -> 1970) and a
currency value ("$19.99" -> 0.0). Verified failing on the 0.1.3 code and
passing on the fix under Ruby 3.4.9.

Guard array and serialization vivify paths against coercion

Close the two coverage gaps the v0.1.3 regression exposed beyond
construction/assignment:

- Marshal and YAML round-trips of a number-like string value ("01970"):
  init_with and marshal_load both call vivify, so 0.1.3 corrupted
  deserialized strings too. These fail on 0.1.3, pass on the fix.
- A number-like string inside an array: vivify_array was never broken,
  so this is a forward-guard against reintroducing coercion there.

Revert "Guard array and serialization vivify paths against coercion"

This reverts commit a027343. Those test additions were pushed without
sign-off; backing them out restores the branch to the reviewed state
(regression fix, version bump, and construction/assignment specs).
---
 lib/flexor/version.rb                  |  2 +-
 lib/flexor/vivification.rb             | 13 ++------
 patterns_spec.rb                       | 10 ------
 spec/flexor/flexor_constructor_spec.rb | 42 ++++++++++++++++++++++++++
 spec/flexor/flexor_writing_spec.rb     | 14 +++++++++
 5 files changed, 59 insertions(+), 22 deletions(-)
 delete mode 100644 patterns_spec.rb

diff --git a/lib/flexor/version.rb b/lib/flexor/version.rb
index 98d90af..9b0affa 100644
--- a/lib/flexor/version.rb
+++ b/lib/flexor/version.rb
@@ -1,3 +1,3 @@
 class Flexor
-  VERSION = "0.1.3".freeze
+  VERSION = "0.1.4".freeze
 end
diff --git a/lib/flexor/vivification.rb b/lib/flexor/vivification.rb
index c18faf5..51ac5d1 100644
--- a/lib/flexor/vivification.rb
+++ b/lib/flexor/vivification.rb
@@ -2,10 +2,6 @@ class Flexor
   ##
   # Methods for recursively converting raw Hashes and Arrays into Flexor objects.
   module Vivification
-    FLOAT = /[0-9.-]+/
-    INTEGER = /^(?<!0)[0-9-]+/
-    DATELIKE = /^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}/
-
     private
 
     def vivify(hash)
@@ -22,13 +18,8 @@ def vivify(hash)
 
     def vivify_value(value)
       case value
-      in Hash then self.class.new(value, root: false)
-      in Array then vivify_array(value)
-      in INTEGER then value.to_i
-      in FLOAT then value.to_f
-      in DATELIKE
-        require "datetime"
-        DateTime.parse(it)
+      when Hash then self.class.new(value, root: false)
+      when Array then vivify_array(value)
       else value
       end
     end
diff --git a/patterns_spec.rb b/patterns_spec.rb
deleted file mode 100644
index 926e1ea..0000000
--- a/patterns_spec.rb
+++ /dev/null
@@ -1,10 +0,0 @@
-require "rspec"
-
-FLOAT = /^(?:(?<!0)(?:[-+] ?)?[0-9])+(?:\.(?:[0-9](?!\.))+)?$/
-RSpec.describe "Patterns" do
-  describe FLOAT do
-    it "does not allow leading zeroes" do
-      skip "not done yet"
-    end
-  end
-end
diff --git a/spec/flexor/flexor_constructor_spec.rb b/spec/flexor/flexor_constructor_spec.rb
index 73df1be..b4f495a 100644
--- a/spec/flexor/flexor_constructor_spec.rb
+++ b/spec/flexor/flexor_constructor_spec.rb
@@ -104,6 +104,48 @@
       end
     end
 
+    context "with string values that resemble numbers or dates" do
+      it "preserves a string of digits as a string" do
+        store = described_class.new({ zip: "10001" })
+        expect(store.zip).to eq "10001"
+      end
+
+      it "preserves a leading-zero string without stripping the zeroes" do
+        store = described_class.new({ zip: "01970" })
+        expect(store.zip).to eq "01970"
+      end
+
+      it "preserves a currency string instead of zeroing it" do
+        store = described_class.new({ price: "$19.99" })
+        expect(store.price).to eq "$19.99"
+      end
+
+      it "preserves a string that merely begins with digits" do
+        store = described_class.new({ address: "123 Main Street" })
+        expect(store.address).to eq "123 Main Street"
+      end
+
+      it "preserves prose that happens to contain a number" do
+        store = described_class.new({ note: "call me at 3pm" })
+        expect(store.note).to eq "call me at 3pm"
+      end
+
+      it "preserves a hyphenated identifier" do
+        store = described_class.new({ phone: "555-1234" })
+        expect(store.phone).to eq "555-1234"
+      end
+
+      it "preserves a decimal-looking string" do
+        store = described_class.new({ version: "1.2.3" })
+        expect(store.version).to eq "1.2.3"
+      end
+
+      it "preserves an ISO-8601 timestamp string" do
+        store = described_class.new({ recorded_at: "2023-01-15T10:30:00" })
+        expect(store.recorded_at).to eq "2023-01-15T10:30:00"
+      end
+    end
+
     context "with a non-hash argument" do
       it "raises ArgumentError for strings" do
         expect { described_class.new("string") }.to raise_error(ArgumentError)
diff --git a/spec/flexor/flexor_writing_spec.rb b/spec/flexor/flexor_writing_spec.rb
index ca997fc..77178c3 100644
--- a/spec/flexor/flexor_writing_spec.rb
+++ b/spec/flexor/flexor_writing_spec.rb
@@ -148,6 +148,20 @@
     end
   end
 
+  describe "assigning a string value that resembles a number" do
+    subject { described_class.new }
+
+    it "preserves the string via the method setter" do
+      subject.address = "123 Main Street"
+      expect(subject.address).to eq "123 Main Street"
+    end
+
+    it "preserves the string via the hash accessor" do
+      subject[:address] = "123 Main Street"
+      expect(subject[:address]).to eq "123 Main Street"
+    end
+  end
+
   describe "#set_raw" do
     subject { described_class.new }