From b7c9349efc40fbf1165fb4947f089ffc283d9002 Mon Sep 17 00:00:00 2001 From: Daeho Ro <40587651+daeho-ro@users.noreply.github.com> Date: Sat, 10 Oct 2026 16:03:28 +0900 Subject: [PATCH] utils::sqlite: restore static on test helpers 157fb89d replaced UTILS_UNUSED with [[maybe_unused]] but dropped `static` from the forward declarations of create_test_table() and verify_test_table(), while their definitions are still static. GCC rejects this ("was declared 'extern' and later 'static'"), so building with --enable-atf fails on Linux. CI only builds with clang, which accepts it. Restore `static` and place the attribute after the declarator, as done elsewhere in 157fb89d. Fixes: 157fb89d ("Replace KYUA_ATTRIBUTE_{NORETURN,UNUSED}} ...") Signed-off-by: Daeho Ro <40587651+daeho-ro@users.noreply.github.com> --- utils/sqlite/test_utils.hpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/sqlite/test_utils.hpp b/utils/sqlite/test_utils.hpp index ba6b720b..92725703 100644 --- a/utils/sqlite/test_utils.hpp +++ b/utils/sqlite/test_utils.hpp @@ -97,7 +97,7 @@ static const char* create_test_table_sql = "INSERT INTO test (prime) VALUES (3);\n"; -[[maybe_unused]] void create_test_table(::sqlite3*); +static void create_test_table [[maybe_unused]] (::sqlite3*); /// Creates a 'test' table in a database. @@ -118,7 +118,7 @@ create_test_table(::sqlite3* db) } -[[maybe_unused]] void verify_test_table(::sqlite3*); +static void verify_test_table [[maybe_unused]] (::sqlite3*); /// Verifies that the specified database contains the 'test' table.