From 4e57d936c7cf626de0bbf8c4efbe0c5f8f2f580d Mon Sep 17 00:00:00 2001 From: Guillaume Bernos Date: Mon, 13 Jul 2026 11:20:09 +0200 Subject: [PATCH 1/2] chore(auth,windows): clean up logs --- packages/firebase_auth/firebase_auth/windows/CMakeLists.txt | 2 -- .../firebase_auth/windows/firebase_auth_plugin.cpp | 5 +---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/firebase_auth/firebase_auth/windows/CMakeLists.txt b/packages/firebase_auth/firebase_auth/windows/CMakeLists.txt index 74c8f9abd4e5..043ffa684103 100644 --- a/packages/firebase_auth/firebase_auth/windows/CMakeLists.txt +++ b/packages/firebase_auth/firebase_auth/windows/CMakeLists.txt @@ -58,8 +58,6 @@ apply_standard_settings(${PLUGIN_NAME}) set_target_properties(${PLUGIN_NAME} PROPERTIES CXX_VISIBILITY_PRESET hidden) target_compile_definitions(${PLUGIN_NAME} PUBLIC FLUTTER_PLUGIN_IMPL) -# Enable firebase-cpp-sdk's platform logging api. -target_compile_definitions(${PLUGIN_NAME} PRIVATE -DINTERNAL_EXPERIMENTAL=1) # Source include directories and library dependencies. Add any plugin-specific # dependencies here. diff --git a/packages/firebase_auth/firebase_auth/windows/firebase_auth_plugin.cpp b/packages/firebase_auth/firebase_auth/windows/firebase_auth_plugin.cpp index a931dac2b36b..dfc130f8ef23 100644 --- a/packages/firebase_auth/firebase_auth/windows/firebase_auth_plugin.cpp +++ b/packages/firebase_auth/firebase_auth/windows/firebase_auth_plugin.cpp @@ -13,7 +13,6 @@ #include "firebase/app.h" #include "firebase/auth.h" #include "firebase/future.h" -#include "firebase/log.h" #include "firebase/util.h" #include "firebase/variant.h" #include "firebase_auth/plugin_version.h" @@ -65,9 +64,7 @@ void FirebaseAuthPlugin::RegisterWithRegistrar( nullptr); } -FirebaseAuthPlugin::FirebaseAuthPlugin() { - firebase::SetLogLevel(firebase::kLogLevelVerbose); -} +FirebaseAuthPlugin::FirebaseAuthPlugin() = default; FirebaseAuthPlugin::~FirebaseAuthPlugin() = default; From 7e1765d6bd364ea7a576660734645a4e708f1122 Mon Sep 17 00:00:00 2001 From: Guillaume Bernos Date: Mon, 13 Jul 2026 14:11:59 +0200 Subject: [PATCH 2/2] clean --- packages/firebase_auth/firebase_auth/windows/CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/firebase_auth/firebase_auth/windows/CMakeLists.txt b/packages/firebase_auth/firebase_auth/windows/CMakeLists.txt index 043ffa684103..834880ff08b5 100644 --- a/packages/firebase_auth/firebase_auth/windows/CMakeLists.txt +++ b/packages/firebase_auth/firebase_auth/windows/CMakeLists.txt @@ -58,6 +58,8 @@ apply_standard_settings(${PLUGIN_NAME}) set_target_properties(${PLUGIN_NAME} PROPERTIES CXX_VISIBILITY_PRESET hidden) target_compile_definitions(${PLUGIN_NAME} PUBLIC FLUTTER_PLUGIN_IMPL) +# Enable Firebase C++ SDK internal APIs used by App::RegisterLibrary. +target_compile_definitions(${PLUGIN_NAME} PRIVATE -DINTERNAL_EXPERIMENTAL=1) # Source include directories and library dependencies. Add any plugin-specific # dependencies here.