diff --git a/source/common/formatter/http_specific_formatter.cc b/source/common/formatter/http_specific_formatter.cc index 2444ba8590a5b..04346b845fe5c 100644 --- a/source/common/formatter/http_specific_formatter.cc +++ b/source/common/formatter/http_specific_formatter.cc @@ -631,7 +631,7 @@ BuiltInHttpCommandParser::parse(absl::string_view command, absl::string_view sub } // Check flags for the command. - THROW_IF_NOT_OK( + RETURN_IF_NOT_OK( CommandSyntaxChecker::verifySyntax((*it).second.first, command, subcommand, max_length)); // Create a pointer to the formatter by calling a function diff --git a/test/common/formatter/BUILD b/test/common/formatter/BUILD index 7def75b7c5952..7b4b7956926e5 100644 --- a/test/common/formatter/BUILD +++ b/test/common/formatter/BUILD @@ -68,6 +68,7 @@ envoy_cc_test( "//test/mocks/upstream:cluster_info_mocks", "//test/test_common:environment_lib", "//test/test_common:simulated_time_system_lib", + "//test/test_common:status_utility_lib", "//test/test_common:test_runtime_lib", "//test/test_common:threadsafe_singleton_injector_lib", "//test/test_common:utility_lib", diff --git a/test/common/formatter/substitution_formatter_test.cc b/test/common/formatter/substitution_formatter_test.cc index 0de136ce75b0e..c3a4cec0c1618 100644 --- a/test/common/formatter/substitution_formatter_test.cc +++ b/test/common/formatter/substitution_formatter_test.cc @@ -31,6 +31,7 @@ #include "test/test_common/environment.h" #include "test/test_common/printers.h" #include "test/test_common/simulated_time_system.h" +#include "test/test_common/status_utility.h" #include "test/test_common/test_runtime.h" #include "test/test_common/threadsafe_singleton_injector.h" #include "test/test_common/utility.h" @@ -38,6 +39,7 @@ #include "gmock/gmock.h" #include "gtest/gtest.h" +using Envoy::StatusHelpers::HasStatus; using testing::Const; using testing::HasSubstr; using testing::Invoke; @@ -5930,8 +5932,8 @@ TEST(SubstitutionFormatterTest, CoalesceFormatterGridTest) { TEST(SubstitutionFormatterTest, CoalesceFormatterErrorCases) { // Empty JSON config. { - EXPECT_THROW_WITH_MESSAGE(SubstitutionFormatParser::parse("%COALESCE()%").IgnoreError(), - EnvoyException, "COALESCE requires parameters"); + EXPECT_THAT(SubstitutionFormatParser::parse("%COALESCE()%"), + HasStatus(absl::StatusCode::kInvalidArgument, "COALESCE requires parameters")); } // Invalid JSON.