From f8b47493619e07e386286865a291857d367c828f Mon Sep 17 00:00:00 2001 From: Valere Date: Fri, 7 Aug 2026 20:46:02 +0200 Subject: [PATCH 1/2] fix test using private field --- .../settings/controllers/FallbackIceServerController.test.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/web/src/settings/controllers/FallbackIceServerController.test.ts b/apps/web/src/settings/controllers/FallbackIceServerController.test.ts index 57019e6851c..35fa367ad39 100644 --- a/apps/web/src/settings/controllers/FallbackIceServerController.test.ts +++ b/apps/web/src/settings/controllers/FallbackIceServerController.test.ts @@ -48,12 +48,13 @@ describe("FallbackIceServerController", () => { MatrixClientBackedController.matrixClient = client; expect(controller.settingDisabled).toBeFalsy(); - client["clientWellKnown"] = { + const wn = { "io.element.voip": { disable_fallback_ice: true, }, }; - client.emit(ClientEvent.ClientWellKnown, client["clientWellKnown"]); + vi.spyOn(client, "getClientWellKnown").mockResolvedValue(wn); + client.emit(ClientEvent.ClientWellKnown, wn); expect(controller.settingDisabled).toBeTruthy(); }); From 8b570c532bf12aa1dec3fffd082e1b70c0614562 Mon Sep 17 00:00:00 2001 From: Valere Date: Sat, 8 Aug 2026 15:34:03 +0200 Subject: [PATCH 2/2] review: use readable name --- .../controllers/FallbackIceServerController.test.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/web/src/settings/controllers/FallbackIceServerController.test.ts b/apps/web/src/settings/controllers/FallbackIceServerController.test.ts index 35fa367ad39..a777d641134 100644 --- a/apps/web/src/settings/controllers/FallbackIceServerController.test.ts +++ b/apps/web/src/settings/controllers/FallbackIceServerController.test.ts @@ -48,13 +48,13 @@ describe("FallbackIceServerController", () => { MatrixClientBackedController.matrixClient = client; expect(controller.settingDisabled).toBeFalsy(); - const wn = { + const wellKnown = { "io.element.voip": { disable_fallback_ice: true, }, }; - vi.spyOn(client, "getClientWellKnown").mockResolvedValue(wn); - client.emit(ClientEvent.ClientWellKnown, wn); + vi.spyOn(client, "getClientWellKnown").mockResolvedValue(wellKnown); + client.emit(ClientEvent.ClientWellKnown, wellKnown); expect(controller.settingDisabled).toBeTruthy(); });