Skip to content

Commit d373a00

Browse files
marc0oloclaude
andcommitted
chore(ci): bump the dev-env image to v2.2.1 and drop the mops prewarm
v2.2.1 ships mops 3.2.2, which fixes the toolchain download race (caffeinelabs/mops#818) that the prewarm step worked around, so the step goes with it. Verified locally: `icp build` on motoko/pub-sub with a cold moc cache and no prewarm is 3/3 clean on 3.2.2, against 3/3 failures on the 3.1.0 that v2.0.0 shipped. 3.2.2 also closes GHSA-7w5x-hrqm-74c2 (CVSS 8.2), where a malformed mops.toml reached during dependency resolution hangs the parser. The image also moves icp-cli 1.3.0 -> 1.5.0, Node 24.15 -> 24.21, pnpm 11.4 -> 11.26 and yq 4.53.3 -> 4.53.6. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent 209028c commit d373a00

2 files changed

Lines changed: 2 additions & 13 deletions

File tree

‎.devcontainer/devcontainer.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ICP Examples (Motoko + Rust)",
3-
"image": "ghcr.io/dfinity/icp-dev-env-all:v2.0.0",
3+
"image": "ghcr.io/dfinity/icp-dev-env-all:v2.2.1",
44
"forwardPorts": [8000, 5173],
55
"portsAttributes": {
66
"8000": {

‎.github/workflows/_run-example.yml‎

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ on:
5050
jobs:
5151
run:
5252
runs-on: ubuntu-24.04
53-
container: ghcr.io/dfinity/icp-dev-env-${{ inputs.language }}:v2.0.0
53+
container: ghcr.io/dfinity/icp-dev-env-${{ inputs.language }}:v2.2.1
5454
env:
5555
ICP_CLI_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5656
steps:
@@ -60,17 +60,6 @@ jobs:
6060
uses: dfinity/pocketic@a980c334fab1b21b0b8a6bba38e1a10836e7258b # main
6161
with:
6262
pocket-ic-server-version: ${{ inputs.pocketic-version }}
63-
# Projects with more than one Motoko canister run one `mops build` per canister
64-
# concurrently, and those invocations race on the shared moc toolchain download and
65-
# extraction: whichever build loses reads a half-extracted moc and fails with no
66-
# diagnostics. Warming the cache first makes the download happen exactly once.
67-
# Remove once caffeinelabs/mops#818 is fixed and released.
68-
- name: Warm the mops toolchain cache
69-
working-directory: ${{ inputs.working-directory }}
70-
run: |
71-
if [ -f mops.toml ] && command -v mops > /dev/null; then
72-
mops install
73-
fi
7463
- name: Run
7564
working-directory: ${{ inputs.working-directory }}
7665
run: ${{ inputs.run }}

0 commit comments

Comments
 (0)