Repository navigation
Commit 2185000
chore(hosting): drop the photo-storage example (#1478)
* chore(hosting): drop the photo-storage example
The example demonstrated programmatic, end-user-facing uploads via
AssetManager from @icp-sdk/canisters/assets — an API only the legacy
asset canister provides. We no longer want to advertise the asset
canister as programmatic storage, so the example is retired rather than
reworked or kept on the legacy recipe.
Rework was not viable: certified-assets exposes no runtime-upload API
(mutations go exclusively through the recipe's sync plugin on
`icp deploy`), and repurposing it onto a purpose-built backend canister
would duplicate rust/photo_gallery.
photo-storage was also the only example still pinned to
@dfinity/asset-canister, so all frontends in the repo now run on
@dfinity/static-site (certified-assets).
Removed alongside the example directory:
- .github/workflows/hosting-photo-storage-example.yml
- its CODEOWNERS entry
- both hosting/README.md entries, including the "one deliberate
exception" note about the legacy recipe
- the photo-storage reference in the AGENTS.md ICP Ninja eligibility
rules (genericized; the controller-only-setup rule itself stands)
Closes the long-term decision left open in #1459; resolves item 1 of #1458.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* docs: disambiguate the retired asset canister from certified-assets
The retired asset canister's source lives in dfinity/sdk under
src/canisters/frontend (ic-frontend-canister is the wasm;
ic-certified-assets the library it wraps; ic-asset the upload/sync
library holding security_policy.rs). Its crate is *also* named
`ic-certified-assets`, so an agent told "use certified-assets, not the
legacy asset canister" can search GitHub, land in the sdk crate, and
read the wrong source with full confidence. AGENTS.md now names both
locations at the point where the legacy config is banned.
hosting/README.md linked "asset canister" at
docs.internetcomputer.org/guides/frontends/asset-canister. That page is
still live but wholly legacy — it teaches `.ic-assets.json5` SPA
routing, AssetManager programmatic uploads, and
`http://<canister-id>.localhost:8000` URLs, i.e. the three things these
examples no longer do. Keeping the orienting clause but dropping the
link, so readers aren't sent to a page that contradicts every example it
introduces.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>1 parent b4fe175 commit 2185000
22 files changed
Lines changed: 3 additions & 2309 deletions
File tree
- .github
- workflows
- hosting
- photo-storage
- public/uploads
- src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
225 | | - | |
| 225 | + | |
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
| |||
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
444 | | - | |
| 444 | + | |
445 | 445 | | |
446 | 446 | | |
447 | 447 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
This file was deleted.
This file was deleted.
This file was deleted.
0 commit comments