feat(resource): add external url override to ResourceViewer - #1215
Merged
Merged
Conversation
Contributor
|
Instead of having a prop passing by every component, should it be better to use the datagouv-components config to specify the resourceExternalUrl? |
Contributor
Author
|
@ThibaudDauce simpler, done. |
ThibaudDauce
approved these changes
Sep 7, 2026
ThibaudDauce
pushed a commit
that referenced
this pull request
Sep 17, 2026
Follow up #1215 Related opendatateam/udata-front-kit#1373 I've been too eager to follow the review comments there. We actually need prop rather than config downstream: the component is mounted in different contexts/pages and thus a prop is better suited to configure the component. This removes the config key and adds the props. It also handles `ResourceAccordion.vue` that was left out before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related opendatateam/udata-front-kit#1373
Allows to override the resource external url used for "Copier le lien" target. Useful for front-kit verticals.