ciRunUrl for GitHub Actions?

[dandean]

Hello,

I noticed that ciRunUrl is not implemented here: https://github.com/danger/danger-js/blob/main/source/ci_source/providers/GitHubActions.ts#L272-L275

I found this because I'm having to switch from using the status integration to --use-github-checks in my own workflow, as the Danger status links to the Danger website instead of my workflow run's URL.

Before working to put together a PR, is there interest in a submission for this? At a glance, I believe it can be trivially implemented with something like the below, now that all of these environmental variables exist:

get ciRunURL() {
  if (ensureEnvKeysExist(this.env, ["GITHUB_SERVER_URL", "GITHUB_REPOSITORY", "GITHUB_RUN_ID"])) {
    return `${this.env.GITHUB_SERVER_URL}/${this.env.GITHUB_REPOSITORY}/actions/runs/${this.env.GITHUB_RUN_ID}`
  }
  return undefined
}

[fbartho]

I don’t think there’s a problem with doing this. Feel free to make a PR.

I’ve never had a need for this URL personally, so it doesn’t surprise me that it’s not implemented, but I could see a use-case. I probably forgot to look it on the ci-source and just recomposed it for my needs in my dangerfile.

[dandean]

Thanks for the response @fbartho. I'll put a patch together and see if I can test it locally in my own infrastructure to solve what I was running into before opening a PR.