feat: support IS UNKNOWN expressions - #399
Merged
Merged
Conversation
makenowjust
reviewed
Aug 15, 2026
|
|
||
| // IsUnknownExpr is IS UNKNOWN expression node. | ||
| // | ||
| // {{.Left | sql}} IS {{if .Not}}NOT{{end}} UNKNOWN |
Collaborator
There was a problem hiding this comment.
Is this better?
Suggested change
| // {{.Left | sql}} IS {{if .Not}}NOT{{end}} UNKNOWN | |
| // {{.Left | sql}} IS{{if .Not}} NOT{{end}} UNKNOWN |
Contributor
Author
There was a problem hiding this comment.
I think the current form is preferable as documentation. These templates are not intended to specify whitespace exactly, and keeping spaces outside the template actions makes the SQL token boundaries easier to read. Tight adjacency is useful when tokens are intentionally concatenated, such as SAFE_ and CAST, but that is not the case here. This also matches the nearby IsNullExpr and IsBoolExpr templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
IS [NOT] UNKNOWNexpression.