From 874b13a21f454e45eb566dce3056eaa21a2d68b1 Mon Sep 17 00:00:00 2001 From: Ignacio Encinas Date: Thu, 21 Dec 2023 18:45:08 +0100 Subject: [PATCH] lint: enable suspicious-semicolon_rule by default --- verilog/analysis/default_rules.h | 1 + verilog/tools/lint/BUILD | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/verilog/analysis/default_rules.h b/verilog/analysis/default_rules.h index f58e237a4..f89777e19 100644 --- a/verilog/analysis/default_rules.h +++ b/verilog/analysis/default_rules.h @@ -65,6 +65,7 @@ inline constexpr const char* kDefaultRuleSet[] = { "positive-meaning-parameter-name", "constraint-name-style", "suggest-parentheses", + "suspicious-semicolon", "truncated-numeric-literal", // TODO(fangism): enable in production: // TODO(b/155128436): "uvm-macro-semicolon" diff --git a/verilog/tools/lint/BUILD b/verilog/tools/lint/BUILD index 04fd143f6..291850112 100644 --- a/verilog/tools/lint/BUILD +++ b/verilog/tools/lint/BUILD @@ -69,7 +69,7 @@ _linter_test_configs = [ ("signal-name-style", "signal_name_style", False), ("struct-union-name-style", "struct_name_style", True), ("struct-union-name-style", "union_name_style", True), - ("suspicious-semicolon", "suspicious_semicolon", False), + ("suspicious-semicolon", "suspicious_semicolon", True), ("v2001-generate-begin", "generate_begin_module", True), ("void-cast", "void-cast", True), ("undersized-binary-literal", "undersized_binary_literal", True),