test(p2p): provide tail in partial range store - #409
Open
loglapa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #406.
handleRangeRequestnow queriesTailbefore checking the requested range. The focusedpartialRangeStoretest double embedded a nilheader.Store, so its inheritedTailmethod panicked and made the currentmaintest suite fail deterministically.Give the test double an explicit tail at the requested lower bound and implement
Tail, preserving the original test path: the range is not below tail,HasAtremains false, and the assertion still verifies thattois not expanded to the distant head.Validation
go test ./...go vet ./...golangci-lint rungo test ./p2p -run ^'TestExchangeServer_partialRangeNotExpanded$' -count=100\n-go test -race ./p2p -run ^'TestExchangeServer_partialRangeNotExpanded$' -count=20\n-docker run --rm -v "$PWD:/workspace" -w /workspace golang:1.27 go test ./...