Repository navigation
Conversation
… expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Alex <inbox@alexv-pro.ru>
Contributor License Agreement✅ Every human contributor has accepted Cattr CLA version 1. Exempt automation:
CLA SHA-256: |
2 tasks
Member
Author
|
Duplicate of #327 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/cattr-app/server-application/security/code-scanning/2
The best fix is to replace the vulnerable regex with a linear-time, non-ambiguous email check that avoids nested ambiguous quantifiers.
In this file, update the regex in
getModalInvite()(around line 292) to a safer pattern such as:[A-Za-z0-9._%+-]+@[A-Za-z0-9-]+(?:\.[A-Za-z0-9-]+)+This removes the problematic
(\.-?\w+)*-style ambiguity while preserving intended behavior (basic email format validation for invites).Also switch from
regex.exec(email) == nullto!regex.test(email)for simple boolean validation (same functional intent, clearer usage).Suggested fixes powered by Copilot Autofix. Review carefully before merging.