fix: normalize timeout diagnostics

Author: cardmagic

src/runtime.ts

@@ -354,7 +354,7 @@ export class SolidObjectsRuntime {
     options: { timeout: number; deadline: number },
   ): Promise<DeepReadonly<Result>> {
     this.callerWorker ??= new Worker(this)
-    while (performance.now() <= options.deadline) {
+    while (performance.now() < options.deadline) {
       const message = await this.repository.findMessage(messageReference.id)
       if (!message || message.request_id !== messageReference.requestId) {
         throw new Error("message reference no longer identifies this invocation")
@@ -401,20 +401,21 @@ export class SolidObjectsRuntime {
       instance.activation_owner_id !== null &&
       instance.activation_expires_at_ms !== null &&
       Number(instance.activation_expires_at_ms) > diagnostics.nowMilliseconds
-    const waitingOn = instance.paused
-      ? ("actorPaused" as const)
-      : activationLive
-        ? ("activationHeld" as const)
-        : blocker
-          ? ("earlierMessage" as const)
-          : diagnostics.status === "claimed"
-            ? ("messageClaimed" as const)
-            : diagnostics.readyAvailableAtMilliseconds !== undefined &&
-                diagnostics.readyAvailableAtMilliseconds > diagnostics.nowMilliseconds
-              ? ("notYetAvailable" as const)
-              : diagnostics.status === "ready"
-                ? ("readyUnclaimed" as const)
-                : ("unknown" as const)
+    const waitingOn =
+      Number(instance.paused) !== 0
+        ? ("actorPaused" as const)
+        : activationLive
+          ? ("activationHeld" as const)
+          : blocker
+            ? ("earlierMessage" as const)
+            : diagnostics.status === "claimed"
+              ? ("messageClaimed" as const)
+              : diagnostics.readyAvailableAtMilliseconds !== undefined &&
+                  diagnostics.readyAvailableAtMilliseconds > diagnostics.nowMilliseconds
+                ? ("notYetAvailable" as const)
+                : diagnostics.status === "ready"
+                  ? ("readyUnclaimed" as const)
+                  : ("unknown" as const)
     const error = new SyncTimeout({
       details: {
         timeoutMilliseconds,

test/housekeeping.test.ts

@@ -19,7 +19,7 @@ afterEach(async () => {
 
 describe("scheduled housekeeping", () => {
   it("does not schedule disabled housekeeping", async () => {
-    runtime = configuredRuntime()
+    runtime = configuredRuntime({ workerCount: 1 })
     await runtime.install()
     const prune = vi.spyOn(runtime.repository, "pruneRetention")
     const cleanup = vi.spyOn(runtime.repository, "cleanupStaleProcesses")
@@ -170,7 +170,7 @@ function configuredRuntime(
     authorizeQuery: () => true,
     authorizeDestroy: () => true,
     authorizeAdministration: () => true,
-    workerCount: 1,
+    workerCount: 0,
     effectWorkerCount: 0,
     reminderSchedulerCount: 0,
     broadcastWorkerCount: 0,

test/sync-timeout.test.ts

@@ -123,6 +123,19 @@ describe("synchronous timeout diagnostics", () => {
       TimeoutActor.ref("invalid").with({ timeoutMilliseconds: -1 }).increment(),
     ).rejects.toThrow("timeoutMilliseconds must be a non-negative number")
   })
+
+  it("does not assist execution when the timeout is zero", async () => {
+    runtime = configuredRuntime()
+    await runtime.install()
+
+    const error = await captureTimeout(() =>
+      TimeoutActor.ref("immediate").with({ timeoutMilliseconds: 0 }).increment(),
+    )
+
+    expect(error.details.waitingOn).toBe("readyUnclaimed")
+    expect(await error.messageReference.status()).toBe("ready")
+    expect(await error.messageReference.wait({ timeoutMilliseconds: 1_000 })).toBe(1)
+  })
 })
 
 function configuredRuntime(