From b66d9460fa061a3f5c73f38c24fd34fe64cde1a0 Mon Sep 17 00:00:00 2001 From: Gustavo Bordoni Date: Thu, 15 Oct 2026 01:28:36 +0000 Subject: [PATCH] ci: run everything on Node 24 softprops/action-gh-release v2 runs on Node 20, which GitHub now forces onto Node 24 with a deprecation warning; v3 is the Node 24 line with the same inputs. zip.yml never set up Node, so the release ZIP's assets were built with whatever the runner image defaults to. It now reads .nvmrc like the test jobs. .nvmrc, the engines field and the README move from 20 to 24. Build and tsc pass locally on Node 24.21. --- .github/workflows/release-attach-zip.yml | 2 +- .github/workflows/zip.yml | 7 +++++++ .nvmrc | 2 +- README.md | 2 +- package.json | 2 +- 5 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release-attach-zip.yml b/.github/workflows/release-attach-zip.yml index a1c0bdf..bd64421 100644 --- a/.github/workflows/release-attach-zip.yml +++ b/.github/workflows/release-attach-zip.yml @@ -49,7 +49,7 @@ jobs: echo "ZIP_FILE=$ZIP_NAME" >> $GITHUB_ENV - name: Attach ZIP to release - uses: softprops/action-gh-release@v2 + uses: softprops/action-gh-release@v3 with: files: ${{ env.ZIP_FILE }} tag_name: ${{ github.event.inputs.tag_name || github.event.release.tag_name }} diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index c6acf54..cdce0ea 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -40,6 +40,13 @@ jobs: php-version: '8.2' tools: composer + # wp-scripts runs on Node (bun only installs and launches it), so pin the + # same version the tests build with instead of the runner's default. + - name: Setup Node + uses: actions/setup-node@v6 + with: + node-version-file: '.nvmrc' + - name: Install bun run: | curl -fsSL https://bun.sh/install | bash diff --git a/.nvmrc b/.nvmrc index 209e3ef..a45fd52 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -20 +24 diff --git a/README.md b/README.md index e28ba64..1674fdd 100644 --- a/README.md +++ b/README.md @@ -766,7 +766,7 @@ All commands that display data support these output formats: - PHP 7.4+ - Composer -- Node.js 20+ +- Node.js 24+ - bun - [slic](https://github.com/stellarwp/slic) (for running tests) diff --git a/package.json b/package.json index 71c3445..39ab85e 100644 --- a/package.json +++ b/package.json @@ -22,6 +22,6 @@ "typescript": "^5.5.0" }, "engines": { - "node": ">=20" + "node": ">=24" } }