Skip to content

(chore): show fiat value alongside UTXO amounts - #880

Open
oyetanishq wants to merge 2 commits into
bitcoinppl:masterfrom
oyetanishq:utxo-list-fiat-values
Open

(chore): show fiat value alongside UTXO amounts#880
oyetanishq wants to merge 2 commits into
bitcoinppl:masterfrom
oyetanishq:utxo-list-fiat-values

Conversation

@oyetanishq

@oyetanishq oyetanishq commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Closes: #859
Each row on the Manage UTXOs screen now shows its fiat value in brackets after the Bitcoin amount, e.g. "50,000 SATS ($31.25)". Falls back to the Bitcoin amount alone when no price is available.

IOS Android
image image

Testing

Platform Coverage

  • Tested on iOS device
  • Tested on Android device
  • Tested on iOS simulator
  • Tested on Android simulator
  • Not tested

Checklist

@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: bitcoinppl/cove/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6f899f60-8293-434b-81c5-fce27bf18861

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

The PR appears safe to merge, with a non-blocking Android layout issue that should be addressed to keep UTXO labels and addresses readable.

Findings

  1. P2 Amount Can Collapse Labels ▶

Summary
  • Extracts reusable fiat conversion and formatting helpers without changing existing wallet-manager behavior.
  • Observes app-level price and selected-currency changes on both mobile platforms.
  • Adds unit coverage for supported units, currencies, and missing-price fallback.
  • The Android row needs an additional width constraint to prevent long amounts from collapsing UTXO identity details.

Diagram

 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  App[AppManager prices and currency] --> IOS[iOS UTXO row]
  App --> Android[Android UTXO row]
  IOS --> Wrapper[CoinControlManager wrapper]
  Android --> Wrapper
  Wrapper --> FFI[UniFFI displayAmountWithFiat]
  FFI --> Formatter[Rust Bitcoin and fiat formatter]
  Formatter --> Text[Bitcoin amount plus optional fiat value]
Loading

greptile-apps[bot]
greptile-apps Bot reviewed Sep 8, 2026
View reviewed changes
Comment thread android/app/src/main/java/org/bitcoinppl/cove/flows/CoinControlFlow/UtxoListScreen.kt
Comment on lines 518 to +525
Column(horizontalAlignment = Alignment.End) {
Text(
manager.displayAmount(utxo.amount),
amountText,
fontWeight = FontWeight.Normal,
fontSize = 13.sp,
color = MaterialTheme.colorScheme.onSurface,
maxLines = 1,
overflow = TextOverflow.Ellipsis,

@greptile-apps greptile-apps Bot Sep 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Amount Can Collapse Labels

The expanded amount column has no width constraint, so a long Bitcoin-plus-fiat value can consume nearly all of the row on compact screens or with enlarged text. This leaves little room for the weighted name and address column, making the UTXO hard to identify. Please constrain both sides or preserve a minimum width for the identifying column, as the iOS row does.

Knowledge Base Used:

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@oyetanishq

oyetanishq commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

please review this pr!! @praveenperera

@praveenperera

praveenperera commented Sep 18, 2026

Copy link
Copy Markdown
Member

seeing this it all being in one line is a bit busy, maybe it should be in its own line, and at the bottom when UTXOs are selected it could show the aggregate value in the same line tho

@oyetanishq

oyetanishq commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

how is this?
should I keep it sticky to top?

image

@praveenperera

praveenperera commented Sep 25, 2026

Copy link
Copy Markdown
Member

That’s much better @oyetanishq thanks. I’m currently testing to release the v1.4.0 beta. Once that's done testing I will launch this in

@oyetanishq
(chore): move UTXO fiat value to its own line, add fiat to selected t…
a0eb407 
…otal

Signed-off-by: Tanishq Singh <hello@tanishqsingh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show fiat value in brackets on the Manage UTXOs screen

2 participants

@oyetanishq @praveenperera