lyrics: add --no-keep-synced CLI option#6769
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
grug see PR add new CLI flag for lyrics plugin. goal: one manual beet lyrics run can ignore config keep_synced: yes and not skip synced-lyrics items.
Changes:
- add
--no-keep-syncedoption to lyrics command, mapping tokeep_synced=False - add pytest for config-vs-CLI precedence for
keep_synced - update lyrics plugin docs + changelog entry
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
beetsplug/lyrics.py |
add --no-keep-synced CLI option (inverse of --keep-synced) |
test/plugins/test_lyrics.py |
add test for CLI overriding keep_synced config |
docs/plugins/lyrics.rst |
document new --no-keep-synced usage |
docs/changelog.rst |
add unreleased changelog note for new option |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6769 +/- ##
=======================================
Coverage 75.15% 75.16%
=======================================
Files 163 163
Lines 21042 21043 +1
Branches 3312 3312
=======================================
+ Hits 15814 15816 +2
Misses 4470 4470
+ Partials 758 757 -1
🚀 New features to boost your workflow:
|
snejus
force-pushed
the
lyrics-add-no-keep-synced-cli-opt
branch
3 times, most recently
from
35aa3f9 to
eeb1960
Compare
- Allow manual lyrics fetches to override keep_synced configuration for a single run.
snejus
force-pushed
the
lyrics-add-no-keep-synced-cli-opt
branch
from
eeb1960 to
d9a1bde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beetsplug/lyrics.py:--no-keep-synced. It is the inverse of--keep-synced, and lets one manuallyricsrun ignore the configuredkeep_synced: yes.