From 0456c6580da86e5371de3788550f3b7a2420a3f4 Mon Sep 17 00:00:00 2001 From: Dan Halperin Date: Tue, 21 Jul 2026 17:31:14 +0000 Subject: [PATCH] eos_evpn_multiple_rts: re-sickbay after route-target fixes landed batfish/batfish#10113 (multiple import/export route-targets) and batfish/batfish#10116 (send-community extended on EVPN neighbors) are fixed on Batfish master, so both cross-VRF routes now reach the main RIB and test_main_rib_routes passes. Drop its sickbay entry. test_bgp_rib_routes and test_evpn_rib_routes still xfail, but only on the pre-existing locally-originated path-attribute divergence (lab-validation#152), not route targets. Re-point their sickbay reasons accordingly. ---- Prompt: ``` Re-triage the eos_evpn_multiple_rts lab against Batfish master now that the route-target fixes have merged, and update the sickbay to match the current pass/fail state. ``` --- .../eos_evpn_multiple_rts/source/README.md | 13 ++++++----- .../validation/sickbay.yaml | 22 +++++++++---------- 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/snapshots/eos_evpn_multiple_rts/source/README.md b/snapshots/eos_evpn_multiple_rts/source/README.md index 060fc5d..62d5d13 100644 --- a/snapshots/eos_evpn_multiple_rts/source/README.md +++ b/snapshots/eos_evpn_multiple_rts/source/README.md @@ -60,9 +60,10 @@ Deployed on cEOS 4.36.0.1F via the `infra/` lab builder, collected, and validated against Batfish. All 6 `checks.yaml` preconditions pass on the real device: both cross-VRF routes import via their non-last RT. -Against Batfish the bug reproduces exactly. `test_main_rib_routes`, -`test_bgp_rib_routes`, and `test_evpn_rib_routes` fail on both leaves -because the imported route is missing (RED lacks `10.2.2.2/32`, BLUE -lacks `10.1.1.1/32`). These are sickbayed to xfail against -batfish/batfish#10113; remove the entries once Batfish models multiple -import/export RTs. +The multiple-route-target modeling gap (batfish/batfish#10113) and the +related `send-community extended` gap (batfish/batfish#10116) are fixed, +so both cross-VRF routes now reach the main RIB and +`test_main_rib_routes` passes. `test_bgp_rib_routes` and +`test_evpn_rib_routes` still xfail on the pre-existing locally-originated +path-attribute divergence (lab-validation#152), which is unrelated to +route targets and appears in any Arista EVPN lab. diff --git a/snapshots/eos_evpn_multiple_rts/validation/sickbay.yaml b/snapshots/eos_evpn_multiple_rts/validation/sickbay.yaml index 25ca380..b18cbda 100644 --- a/snapshots/eos_evpn_multiple_rts/validation/sickbay.yaml +++ b/snapshots/eos_evpn_multiple_rts/validation/sickbay.yaml @@ -1,22 +1,20 @@ # Expected failures for the multiple-route-target EVPN lab. # -# Batfish's Arista model keeps only a single import and a single export -# EVPN route-target per VRF (last line wins). This lab lists the matching -# RT before an unused decoy in each direction, so Batfish retains only the -# decoy and imports neither cross-VRF route. The real device imports both. -# Tracked in https://github.com/batfish/batfish/issues/10113. +# The multiple import/export route-target modeling gap (batfish#10113) and +# the related send-community extended gap (batfish#10116) are fixed, so the +# cross-VRF routes now reach the main RIB and test_main_rib_routes passes. # -# Remove these entries once Batfish models multiple import/export RTs. +# The remaining BGP/EVPN RIB failures are the known locally-originated +# path-attribute divergence, not route-target related: the device carries +# locally-originated paths (the `network` loopbacks, and each leaf's own +# EVPN Type-5 route with an empty/local AS path and no next hop) that +# Batfish models with different attributes. entries: - - hostname: "leaf[12]" - test_name: test_main_rib_routes - skip: - reason: "Multiple EVPN route-targets collapse to the last one, so the cross-VRF imported route is missing from the VRF RIB. https://github.com/batfish/batfish/issues/10113" - hostname: "leaf[12]" test_name: test_bgp_rib_routes skip: - reason: "Multiple EVPN route-targets collapse to the last one, so the cross-VRF imported route is missing from the BGP RIB. https://github.com/batfish/batfish/issues/10113" + reason: "Locally-originated BGP path attribute divergence (network-statement loopbacks). https://github.com/batfish/lab-validation/issues/152" - hostname: "leaf[12]" test_name: test_evpn_rib_routes skip: - reason: "Multiple EVPN route-targets collapse to the last one, so the imported EVPN Type-5 route is missing. https://github.com/batfish/batfish/issues/10113" + reason: "Locally-originated EVPN Type-5 path attribute divergence (self-originated route, local AS path, no next hop). https://github.com/batfish/lab-validation/issues/152"