Context
From PR #289 review comment by @elldritch:
Ideally, we would load the fingerprints from units that exist on disk from the disk, which would allow us to avoid making the network request larger.
Current Behavior
When restoring cached units, we request ALL units (including skipped ones) from the remote because we need their fingerprint data to populate dep_fingerprints. Even when a unit is already on disk, we fetch its fingerprint from the network.
Proposed Change
For units that already exist on disk (skipped units), read their fingerprints directly from disk and merge them with the network response. This would:
- Reduce network request size
- Reduce server load
- Improve restore performance for partial cache hits
- Potentially be more correct
Location
packages/hurry/src/cargo/cache/restore.rs around line 125-134
🤖 Generated with Claude Code
Context
From PR #289 review comment by @elldritch:
Current Behavior
When restoring cached units, we request ALL units (including skipped ones) from the remote because we need their fingerprint data to populate
dep_fingerprints. Even when a unit is already on disk, we fetch its fingerprint from the network.Proposed Change
For units that already exist on disk (skipped units), read their fingerprints directly from disk and merge them with the network response. This would:
Location
packages/hurry/src/cargo/cache/restore.rsaround line 125-134🤖 Generated with Claude Code