Theme-darkmatter

[olimpiumarius]

DarkMatter theme is broken....

[Goro2030]

Yes, urgent attention is needed!! @chron0

[davidc502]

Does anyone know if this is being looked at or worked?

Best Regards,

[james-hr]

Yes, would love to get this issue resolved.
Also, some of the "Save and Apply" buttons do not work. A workaround is to press enter, and then apply the unsaved changes. But would be nice if it works as it did on older versions.

[Goro2030]

Looks like the project owners have abandoned it. We need a new development leader.

On Thu, Aug 2, 2018 at 13:35 james-hr ***@***.***> wrote: Yes, would love to get this issue resolved. Also, some of the "Save and Apply" buttons do not work. A workaround is to press enter, and then apply the unsaved changes. But would be nice if it works as it did on older versions. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKXxmkAiHU2eTrVMd3cWWVcPSqaoeUR1ks5uMzhXgaJpZM4UfbVu> .

-- Saludos, Mariano

[chron0]

nah, I just don't prioritize the precious little time I have to push projects only to get into stupid arguments with openwrt dev crowd. I tried to get it merged but as you can check on the ML they didn't like that my email adress is chrono@foo so it got rejected. And since openwrt/lede still hasn't managed to get current master going on the ar-300m and other NAND devices I'm stuck on an old 17.01 and can't use current master, therefore I won't be able to fix any bugs they've introduced again.

[chron0]

so, stop whining/demanding, fix it, send PRs and I'll merge it...

[james-hr]

Hey, sorry, I did not mean to make it look like I am demanding or whining, was just reporting that it does not work for me. I know jack about Lua, so I would likely not be able to help at all in that regard.

I can, however, send some $ for coffee, if that will help expand this project.

I know wrt devs are fun to work with at times, so sorry that they are not playing along and your are having issues with them, hopefully that will be resolved soon.

Thank you for giving us an alternative to the otherwise god awful UI :-)

[chron0]

@james-hr: kek, nothing to be sorry about, it's not like I was addressing you specifically :)

In any case, don't worry about the lua, the grunt work is in the css due to a lot of missing ids/classes, so we basically often have to iterate over elements/classes to get a match. This is stupid/tedious work, because as soon as something is changed/added upstream, the counts/elements won't match the css anymore.
I've darkmattered a couple of themeable things, including octoprint, and it's only openwrt/lede which makes it extremely hard for people to create and maintain consistent UX for luci, part of the reason why it looks like it does and why there are so few alternatives...

If I would have the time, I'd focus on completely rewriting it, drop jquery as a dep, to make it even smaller and work closely with whoever is behind luci, to get a better structure for classes and theme capabilities instead of dealing with inconsistent html pages and manually massaging DOM with jquery and wild css selectors.

[jow-]

nah, I just don't prioritize the precious little time I have to push projects only to get into stupid arguments with openwrt dev crowd. I tried to get it merged but as you can check on the ML they didn't like that my email adress is chrono@foo so it got rejected.

Mind to elaborate on that? I neither see past pull requests at https://github.com/openwrt/luci/pulls?utf8=%E2%9C%93&q=darkmatter nor https://github.com/openwrt/openwrt/pulls?utf8=%E2%9C%93&q=darkmatter+ nor https://github.com/openwrt/packages/pulls?utf8=%E2%9C%93&q=darkmatter

The only mailing list conversation matching the keyword "darkmatter" I could find in the archive was https://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg40567.html and https://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg40570.html

At which point did "the openwrt dev crowd" complain about your e-mail address, let alone use it as a basis for rejecting a PR? I am genuinely interested because I am sure you never approached me or the LuCI project on github. The first time I learned about Darkmatter was when I got bug reports about it.