Created .nuspec file - #7
Open
malik0818 wants to merge 7 commits into
Open
Conversation
phrohdoh
reviewed
Aug 10, 2020
added 2 commits
August 10, 2020 15:18
…ttion to check full email address. Added test cases for the cases above.
joshdotexe
reviewed
Aug 11, 2020
| Credentials = new NetworkCredential(username, password); | ||
| } | ||
|
|
||
| public bool IsValidEmail(List<string> excludedDomains, string email) |
There was a problem hiding this comment.
no need to pass the excluded Domains as paramerters . this method can read from the config. Also move to separate class and make static
added 4 commits
August 11, 2020 13:13
Updated nuget Packages for test cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.