SLOP-393: replace removed MWNamespace class; drop dead page_counter reference - #7
Open
tosfos wants to merge 1 commit into
Open
SLOP-393: replace removed MWNamespace class; drop dead page_counter reference#7tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
…olumn - MWNamespace::getCanonicalNamespaces() was removed in MW 1.39 and fatals the Special:WatchAnalytics pages list (default view); use NamespaceInfo::getCanonicalNamespaces() instead. - The #watchers_needed query selected p.page_counter, a page-table column removed in MW 1.25, making the parser function fatal with an SQL error on every use. Drop the view_watch_ratio computation (the data source no longer exists) and rank by fewest watches instead, which preserves the function's purpose.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two MW-compat breakages fixed:
includes/WatchAnalyticsPageTablePager.php—MWNamespace::getCanonicalNamespaces(): theMWNamespaceclass was removed in MediaWiki 1.39, so the Special:WatchAnalytics pages list (the default view) fatals. Replaced withMediaWikiServices::getInstance()->getNamespaceInfo()->getCanonicalNamespaces()(same data, available since 1.34).includes/WatchAnalyticsParserFunctions.php— the{{#watchers_needed:}}query selectedp.page_counter, apagetable column removed in MediaWiki 1.25; every use died withUnknown column 'p.page_counter'. Dropped theview_watch_ratiocomputation (its data source no longer exists in core) and now ranks candidates by fewest watches — preserving the function's "pages that need watchers" purpose.Verification
php -lclean on php:7.4-cli and php:8.2-cli for both files.ERROR 1054 Unknown column 'p.page_counter'; new query shape executes and returns rows.page_counterorMWNamespacereferences anywhere in the repo.Closes SLOP-393.