From af83dce725f1a75e32d50cf38237d7324aec2e99 Mon Sep 17 00:00:00 2001 From: albertlast Date: Sun, 9 Aug 2026 23:31:07 +0200 Subject: [PATCH] Names the icons in the message icon picker The XML for these has value and url attributes and carries the icon's name as its text, so getAttribute('name') is null and every one of the 13 icons in the picker announced itself as "null". Read the same text the title already uses. Signed-off-by: Mathias Papenbrock Signed-off-by: albertlast --- Themes/default/scripts/topic.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Themes/default/scripts/topic.js b/Themes/default/scripts/topic.js index 6b2cd75c57e..cd3bc0ae9c5 100755 --- a/Themes/default/scripts/topic.js +++ b/Themes/default/scripts/topic.js @@ -288,8 +288,12 @@ IconList.prototype.onIconsReceived = function (oXMLDoc) const img = document.createElement('img'); img.src = icon.getAttribute('url'); - img.alt = icon.getAttribute('name'); - img.title = icon.firstChild ? icon.firstChild.nodeValue : ''; + /* + * The icon's name is its text, not an attribute - there has never been + * a name attribute on these. Asking for one gave every icon in the + * picker alt="null". + */ + img.alt = img.title = icon.firstChild ? icon.firstChild.nodeValue : ''; img.style.verticalAlign = 'middle'; span.appendChild(img);