diff --git a/source/src/core/scoring/lkball/LK_DomeEnergy.cc b/source/src/core/scoring/lkball/LK_DomeEnergy.cc index 9ffb2cfb6e1..eb1b6611c03 100644 --- a/source/src/core/scoring/lkball/LK_DomeEnergy.cc +++ b/source/src/core/scoring/lkball/LK_DomeEnergy.cc @@ -1034,15 +1034,14 @@ cubed_root( Real val ) { DerivativeFinderWadj::DerivativeFinderWadj( Vector const & base, Vector const & water, Real w_dist, Real water_adjust ) -: x(14) +: B( base ), + W( water ), + B_to_W( water - base ), + wadj( water_adjust ), + w_dist_( w_dist ), + x(14) { - w_dist_ = w_dist; - wadj = water_adjust; - - B = base; - W = water; - B_to_W = W - B; B_to_W_norm = B_to_W.norm(); B_to_W_norm2 = B_to_W_norm*B_to_W_norm; B_to_W_norm3 = B_to_W_norm2*B_to_W_norm; @@ -1098,21 +1097,19 @@ DerivativeFinderWadj::dWadj_dWater() { DerivativeFinder::DerivativeFinder( Vector const & base, Vector const & water, Vector const & other, Real min_cose, Real min_sine, Real max_cose, Real max_sine, Real w_dist, Real water_adjust ) : + B(base), + W(water), + Ot(other), + W_to_Ot(Ot - W), + B_to_W(W - B), + w_dist_( w_dist ), + wadj( water_adjust ), x(175) { - w_dist_ = w_dist; - wadj = water_adjust; - - B = base; - W = water; - Ot = other; - - W_to_Ot = Ot - W; W_to_Ot_norm = W_to_Ot.norm(); W_to_Ot_norm2 = W_to_Ot_norm*W_to_Ot_norm; W_to_Ot_norm3 = W_to_Ot_norm*W_to_Ot_norm2; - B_to_W = W - B; B_to_W_norm = B_to_W.norm(); B_to_W_norm2 = B_to_W_norm*B_to_W_norm; B_to_W_norm3 = B_to_W_norm2*B_to_W_norm; diff --git a/source/src/numeric/MathVector.hh b/source/src/numeric/MathVector.hh index 97c3029add4..4bcbffaa4b2 100644 --- a/source/src/numeric/MathVector.hh +++ b/source/src/numeric/MathVector.hh @@ -110,7 +110,7 @@ public: /// @brief Clone function /// @return pointer to new Vector< T> - MathVector< T> *clone() const + MathVector *clone() const { return new MathVector< T>( *this); } diff --git a/source/src/protocols/forge/remodel/RemodelGlobalFrame.cc b/source/src/protocols/forge/remodel/RemodelGlobalFrame.cc index 47a5a49d8fb..cc9a829bd80 100644 --- a/source/src/protocols/forge/remodel/RemodelGlobalFrame.cc +++ b/source/src/protocols/forge/remodel/RemodelGlobalFrame.cc @@ -209,7 +209,7 @@ void RemodelGlobalFrame::get_helical_params( core::pose::Pose & pose ) { Matrix3f I = Matrix3f::Identity(); Matrix3f N = 0.5*(H+H.transpose()) - cos(omega)*I; - Vector3f hN; + Vector3f hN{0.0, 0.0, 0.0}; Real scalar = 0; Real max_scalar = -10000000; for ( core::Size i = 0; i<=2; i++ ) { diff --git a/source/src/utility/options/VectorOption_T_.hh b/source/src/utility/options/VectorOption_T_.hh index ca29e322249..c8775398024 100644 --- a/source/src/utility/options/VectorOption_T_.hh +++ b/source/src/utility/options/VectorOption_T_.hh @@ -106,17 +106,8 @@ protected: // Creation /// @brief Copy constructor - inline - VectorOption_T_( VectorOption_T_ const & option ) : - Super( option ) -#ifdef VECTOROPTION_T_FULL_THREAD_SAFETY - , - mutex_() -#endif - { - (*this) = option; - } + VectorOption_T_( VectorOption_T_ const & ) = default; /// @brief Key + description constructor inline diff --git a/source/test/core/fragment/ConstantLengthFragments.cxxtest.hh b/source/test/core/fragment/ConstantLengthFragments.cxxtest.hh index e37dfcc982f..fc913beedec 100644 --- a/source/test/core/fragment/ConstantLengthFragments.cxxtest.hh +++ b/source/test/core/fragment/ConstantLengthFragments.cxxtest.hh @@ -267,11 +267,11 @@ void FragmentConstantLengthTest::test_frag_iterator() { FrameList frames; if ( fragset.region( movemap, pos, pos, len, len, frames ) ) { Frame const& frame ( * ( frames[ 1 ] ) ); - Size val; + Size val = 0; TS_ASSERT( silly_cache.retrieve(frame, 1, val) ); //there should be a value ( return true ) TS_ASSERT_EQUALS( val , pos ); - Size val2; + Size val2 = 999555; // Something non-zero; TS_ASSERT( it != eit ); TS_ASSERT( silly_cache.retrieve( **it , 1, val2) ); //there should be a value ( return true ) TS_ASSERT_EQUALS( val2 , val ); @@ -285,7 +285,7 @@ void FragmentConstantLengthTest::test_frag_iterator() { ConstFrameIterator it = bfragset.begin(); ConstFrameIterator eit= bfragset.end(); for ( Size pos=1 ; it!=eit; ++it ) { - Size val; + Size val = 0; silly_cache.retrieve( **it, 1, val); TS_ASSERT_EQUALS( val, pos ); ++pos; diff --git a/source/test/utility/UTools.cxxtest.hh b/source/test/utility/UTools.cxxtest.hh index 4b517114694..248fe4efaab 100644 --- a/source/test/utility/UTools.cxxtest.hh +++ b/source/test/utility/UTools.cxxtest.hh @@ -133,8 +133,8 @@ public: // ------------------------------------------ // /// @brief test isMarkup function void test_isMarkup() { - double num; - unsigned int end_pos; + double num = 0.0; + unsigned int end_pos = 0; bool res; res = test::utools::isMarkup("something(1.23)", 0, num, end_pos, "MARKUP("); @@ -171,13 +171,13 @@ public: abs_tolerance=0; rel_tolerance=0; error_message=""; res = test::utools::isEq("1 ", - "1 ", abs_tolerance, rel_tolerance, error_message); + "1 ", abs_tolerance, rel_tolerance, error_message); TS_ASSERT_EQUALS(res, true); TS_ASSERT_EQUALS(error_message, ""); abs_tolerance=0; rel_tolerance=0; error_message=""; res = test::utools::isEq("set_rel_tolerance(.1) 1.091 aa 5", - " 1 aa 4.561", abs_tolerance, rel_tolerance, error_message); + " 1 aa 4.561", abs_tolerance, rel_tolerance, error_message); TS_ASSERT_EQUALS(res, true); TS_ASSERT_EQUALS(abs_tolerance, 0); TS_ASSERT_EQUALS(rel_tolerance, .1); @@ -185,7 +185,7 @@ public: abs_tolerance=0; rel_tolerance=0; error_message=""; res = test::utools::isEq("1 set_abs_tolerance(.112)", - "1 set_abs_tolerance(.112)", abs_tolerance, rel_tolerance, error_message); + "1 set_abs_tolerance(.112)", abs_tolerance, rel_tolerance, error_message); TS_ASSERT_EQUALS(res, true); TS_ASSERT_EQUALS(abs_tolerance, .112); TS_ASSERT_EQUALS(rel_tolerance, 0); @@ -193,7 +193,7 @@ public: abs_tolerance=0; rel_tolerance=0; error_message=""; res = test::utools::isEq("1 set_abs_tolerance(.112)set_rel_tolerance(98.765)", - "1 set_abs_tolerance(.2)set_rel_tolerance(.3)", abs_tolerance, rel_tolerance, error_message); + "1 set_abs_tolerance(.2)set_rel_tolerance(.3)", abs_tolerance, rel_tolerance, error_message); TS_ASSERT_EQUALS(res, true); TS_ASSERT_EQUALS(abs_tolerance, .112); TS_ASSERT_EQUALS(rel_tolerance, 98.765); @@ -202,7 +202,7 @@ public: abs_tolerance=0; rel_tolerance=0; error_message=""; res = test::utools::isEq("1.2e-10 set_abs_tolerance(.091) 1 ", - "1.2e-10 set_abs_tolerance(.2) 1.09 ", abs_tolerance, rel_tolerance, error_message); + "1.2e-10 set_abs_tolerance(.2) 1.09 ", abs_tolerance, rel_tolerance, error_message); TS_ASSERT_EQUALS(res, true); TS_ASSERT_EQUALS(abs_tolerance, .091); TS_ASSERT_EQUALS(rel_tolerance, 0); @@ -211,7 +211,7 @@ public: abs_tolerance=0; rel_tolerance=0; error_message=""; res = test::utools::isEq("aa b 1 d set_rel_tolerance(.1) 12 ", - "aa b 1 d set_rel_tolerance(.2) 13 ", abs_tolerance, rel_tolerance, error_message); + "aa b 1 d set_rel_tolerance(.2) 13 ", abs_tolerance, rel_tolerance, error_message); TS_ASSERT_EQUALS(res, true); TS_ASSERT_EQUALS(rel_tolerance, .1); TS_ASSERT_EQUALS(abs_tolerance, 0); @@ -220,20 +220,20 @@ public: abs_tolerance=1; rel_tolerance=0; error_message=""; res = test::utools::isEq("aa b 1 d set_abs_tolerance(.0) 12 ", - "aa b 1 d set_abs_tolerance(.2) 13 ", abs_tolerance, rel_tolerance, error_message); + "aa b 1 d set_abs_tolerance(.2) 13 ", abs_tolerance, rel_tolerance, error_message); TS_ASSERT_EQUALS(res, false); TS_ASSERT_DIFFERS(error_message, ""); abs_tolerance=1; rel_tolerance=0; error_message=""; res = test::utools::isEq("aa b x 1 d ", - "aa b 1 d ", abs_tolerance, rel_tolerance, error_message); + "aa b 1 d ", abs_tolerance, rel_tolerance, error_message); TS_ASSERT_EQUALS(res, false); TS_ASSERT_DIFFERS(error_message, ""); abs_tolerance=.1; rel_tolerance=0; error_message=""; res = test::utools::isEq("aa b 10 d ", - "aa b 10.1001 d ", abs_tolerance, rel_tolerance, error_message); + "aa b 10.1001 d ", abs_tolerance, rel_tolerance, error_message); TS_ASSERT_EQUALS(res, false); TS_ASSERT_DIFFERS(error_message, ""); } diff --git a/source/tools/build/basic.settings b/source/tools/build/basic.settings index 29f1e3d6d01..0d4fae07529 100644 --- a/source/tools/build/basic.settings +++ b/source/tools/build/basic.settings @@ -443,6 +443,16 @@ settings = { }, }, + "gcc, |cxx_ver:>=15.0|" : { + "appends" : { + "flags" : { + "warn" : [ + "Wno-error=dangling-pointer=", # Boost spirit issue + ], + }, + }, + }, + "gcc, |cxx_ver:>=13.0|" : { "appends" : { "flags" : {