From a94f90c4c3cf6cce289033d4d71c44cd270e89b7 Mon Sep 17 00:00:00 2001 From: juzo1306 Date: Tue, 10 Nov 2026 15:53:51 +0530 Subject: [PATCH 1/2] added a condition to exclude a self reference to avoid the stackoverflow on the Descriptor property in Resource while using EntrySerialize --- src/Moryx/Serialization/EntryConvert/EntryConvert.cs | 2 +- src/Tests/Moryx.Tests/Moryx.Tests.csproj | 1 + .../EntrySerializeDummies.cs | 7 +++++++ .../EntrySerializeSerializationTests.cs | 10 ++++++++++ 4 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/Moryx/Serialization/EntryConvert/EntryConvert.cs b/src/Moryx/Serialization/EntryConvert/EntryConvert.cs index 84f467ad8..4eacf1bb7 100644 --- a/src/Moryx/Serialization/EntryConvert/EntryConvert.cs +++ b/src/Moryx/Serialization/EntryConvert/EntryConvert.cs @@ -410,7 +410,7 @@ public static Entry EncodeObject(object instance, ICustomSerialization customSer { //exclude property that can lead to self reference var propertyType = property.PropertyType; - if (propertyType == instanceType) + if (propertyType == instanceType || propertyType.IsAssignableFrom(instanceType)) { continue; } diff --git a/src/Tests/Moryx.Tests/Moryx.Tests.csproj b/src/Tests/Moryx.Tests/Moryx.Tests.csproj index bf842cc58..24d70f13c 100644 --- a/src/Tests/Moryx.Tests/Moryx.Tests.csproj +++ b/src/Tests/Moryx.Tests/Moryx.Tests.csproj @@ -9,6 +9,7 @@ + diff --git a/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeDummies.cs b/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeDummies.cs index 3e320f26d..32593bcc5 100644 --- a/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeDummies.cs +++ b/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeDummies.cs @@ -1,6 +1,7 @@ // Copyright (c) 2026 Phoenix Contact GmbH & Co. KG // Licensed under the Apache License, Version 2.0 +using Moryx.AbstractionLayer.Resources; using Moryx.Serialization; namespace Moryx.Tests.Serialization; @@ -124,3 +125,9 @@ public class AlwaysAttributedDerivedType : NeverAttributedBaseType public bool NullProperty3 { get; set; } } + +public class MyResourceWithStateBaseProperty : Resource +{ + [EntrySerialize] + internal MyStateBase State { get; private set; } +} diff --git a/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeSerializationTests.cs b/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeSerializationTests.cs index 140bd05c4..74db23d4b 100644 --- a/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeSerializationTests.cs +++ b/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeSerializationTests.cs @@ -2,6 +2,7 @@ // Licensed under the Apache License, Version 2.0 using System.Globalization; +using Moryx.AbstractionLayer.Resources; using Moryx.Serialization; using NUnit.Framework; @@ -224,4 +225,13 @@ public void ClassWithSerializationAttribute() var alwaysProperties = 3; Assert.That(alwaysProperties, Is.EqualTo(encoded.SubEntries.Count)); } + + [Test] + public void SerializeStateBaseClass() + { + //Arrange + var resource = new MyResourceWithStateBaseProperty(); + Assert.DoesNotThrow(() => EntryConvert.EncodeObject(resource)); + } } + From 18837bbbff93ddbc0e5b07b31f5129f10e23ba41 Mon Sep 17 00:00:00 2001 From: juzo1306 Date: Wed, 11 Nov 2026 11:30:00 +0530 Subject: [PATCH 2/2] Removed the Moryx.AbstractionLayer reference from the Moryx.Tests. Created a derived class whose base has self referencing property . This is the pattern which causes the stack overflow. Now only the Moryx is referenced in the Moryx.Tests which is intentional. --- src/Tests/Moryx.Tests/Moryx.Tests.csproj | 1 - .../EntrySerializeDummies.cs | 10 ++++++---- .../EntrySerializeSerializationTests.cs | 9 ++++----- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/Tests/Moryx.Tests/Moryx.Tests.csproj b/src/Tests/Moryx.Tests/Moryx.Tests.csproj index 24d70f13c..bf842cc58 100644 --- a/src/Tests/Moryx.Tests/Moryx.Tests.csproj +++ b/src/Tests/Moryx.Tests/Moryx.Tests.csproj @@ -9,7 +9,6 @@ - diff --git a/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeDummies.cs b/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeDummies.cs index 32593bcc5..387f65206 100644 --- a/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeDummies.cs +++ b/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeDummies.cs @@ -1,7 +1,6 @@ // Copyright (c) 2026 Phoenix Contact GmbH & Co. KG // Licensed under the Apache License, Version 2.0 -using Moryx.AbstractionLayer.Resources; using Moryx.Serialization; namespace Moryx.Tests.Serialization; @@ -126,8 +125,11 @@ public class AlwaysAttributedDerivedType : NeverAttributedBaseType public bool NullProperty3 { get; set; } } -public class MyResourceWithStateBaseProperty : Resource +public class SelfReferencingBase +{ + public SelfReferencingBase Self { get; set; } +} + +public class SelfReferencingDerived : SelfReferencingBase { - [EntrySerialize] - internal MyStateBase State { get; private set; } } diff --git a/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeSerializationTests.cs b/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeSerializationTests.cs index 74db23d4b..65c67db03 100644 --- a/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeSerializationTests.cs +++ b/src/Tests/Moryx.Tests/Serialization/EntrySerializeSerialization/EntrySerializeSerializationTests.cs @@ -2,7 +2,6 @@ // Licensed under the Apache License, Version 2.0 using System.Globalization; -using Moryx.AbstractionLayer.Resources; using Moryx.Serialization; using NUnit.Framework; @@ -227,11 +226,11 @@ public void ClassWithSerializationAttribute() } [Test] - public void SerializeStateBaseClass() + public void SerializeClassWithSelfReference() { - //Arrange - var resource = new MyResourceWithStateBaseProperty(); - Assert.DoesNotThrow(() => EntryConvert.EncodeObject(resource)); + var instance = new SelfReferencingDerived(); + instance.Self = instance; + Assert.DoesNotThrow(() => EntryConvert.EncodeObject(instance)); } }