From 8814f36875cb810d2be648610c839a33ebfad567 Mon Sep 17 00:00:00 2001 From: Dennis Beuchler Date: Mon, 9 Nov 2026 08:19:02 +0100 Subject: [PATCH 1/3] Made UseButton public on ReadCodeOptions --- src/Moryx.AbstractionLayer/Drivers/Scanner/ReadCodeOptions.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Moryx.AbstractionLayer/Drivers/Scanner/ReadCodeOptions.cs b/src/Moryx.AbstractionLayer/Drivers/Scanner/ReadCodeOptions.cs index 7857fcafad..b7f4de5bb5 100644 --- a/src/Moryx.AbstractionLayer/Drivers/Scanner/ReadCodeOptions.cs +++ b/src/Moryx.AbstractionLayer/Drivers/Scanner/ReadCodeOptions.cs @@ -4,12 +4,12 @@ namespace Moryx.AbstractionLayer.Drivers.Scanner; /// -/// Options for the read of code read +/// Options for the read of code read /// public class ReadCodeOptions { /// /// Determines whether the button of the scanner can be used to initiate a scan or whether it is triggered by the system /// - bool UseButton { get; set; } + public bool UseButton { get; set; } } From 7354c7beee8f6472e97374927706ab591b608684 Mon Sep 17 00:00:00 2001 From: Dennis Beuchler Date: Mon, 9 Nov 2026 08:19:46 +0100 Subject: [PATCH 2/3] Unused Dispose on JobList and NotificationManager --- .../Jobs/Implementation/JobList.cs | 5 ----- src/Moryx.Notifications.Publisher/NotificationManager.cs | 6 +----- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/Moryx.ControlSystem.ProcessEngine/Jobs/Implementation/JobList.cs b/src/Moryx.ControlSystem.ProcessEngine/Jobs/Implementation/JobList.cs index 3acc196b01..8ccba39fd2 100644 --- a/src/Moryx.ControlSystem.ProcessEngine/Jobs/Implementation/JobList.cs +++ b/src/Moryx.ControlSystem.ProcessEngine/Jobs/Implementation/JobList.cs @@ -74,11 +74,6 @@ private void AwaitCleanJobList() nameof(JobList), Config.JobListStopTimeout, string.Join(", ", _jobs.Select(j => j.Id))); } - /// - public void Dispose() - { - } - #endregion /// diff --git a/src/Moryx.Notifications.Publisher/NotificationManager.cs b/src/Moryx.Notifications.Publisher/NotificationManager.cs index 125728e4e7..00295c685c 100644 --- a/src/Moryx.Notifications.Publisher/NotificationManager.cs +++ b/src/Moryx.Notifications.Publisher/NotificationManager.cs @@ -114,10 +114,6 @@ public void Stop() Processors.ForEach(p => p.Stop()); } - public void Dispose() - { - } - private void OnSourceStateChanged(object sender, bool activated) { var source = (INotificationSource)sender; @@ -359,4 +355,4 @@ internal enum NotificationState PendingAcknowledge, Acknowledged, } -} \ No newline at end of file +} From 056fe26701206f40503dc1becd180ced73dcd7ad Mon Sep 17 00:00:00 2001 From: Dennis Beuchler Date: Mon, 9 Nov 2026 08:20:01 +0100 Subject: [PATCH 3/3] Removed double-semicolon from LoginController --- .../Controllers/MVC/LoginController.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Moryx.Identity.AccessManagement/Controllers/MVC/LoginController.cs b/src/Moryx.Identity.AccessManagement/Controllers/MVC/LoginController.cs index 930eec2e83..e6d02ea7aa 100644 --- a/src/Moryx.Identity.AccessManagement/Controllers/MVC/LoginController.cs +++ b/src/Moryx.Identity.AccessManagement/Controllers/MVC/LoginController.cs @@ -74,7 +74,7 @@ public IActionResult Register() public async Task RegisterExecute(MoryxUserRegisterModel userModel) { - var user = ModelConverter.GetUserFromUserRegisterModel(userModel);; + var user = ModelConverter.GetUserFromUserRegisterModel(userModel); var userCreateResult = await _userManager.CreateAsync(user, userModel.Password); if (userCreateResult.Succeeded) @@ -140,4 +140,4 @@ public async Task ResetPassword(MoryxUserResetPasswordModel reset return RedirectToAction("Index", new { returnUrl = returnUrl }); } -} \ No newline at end of file +}