Fuselage layout enhancement and modification#1205
Open
xjjiang wants to merge 44 commits into
Open
Conversation
…ECONOMY. Fixed a bug DetailedCabinLayout. Added business class to DetailedCabinLayout
…ECONOMY. added Aircraft.Fuselage.SEAT_WIDTH_BUSINESS and Aircraft.Fuselage.SEAT_WIDTH_FIRST. removed LEAPS1.
…ge.SEAT_WIDTH_FIRST
xjjiang
changed the title
xjjiang
changed the title
…fect fuselage layout
…t is used for transporter aircraft using FLOPS based geometry.
xjjiang
changed the title
cmbenne3
reviewed
Jul 8, 2026
| else: | ||
| if design_type == AircraftTypes.BLENDED_WING_BODY: | ||
| if verbosity >= Verbosity.BRIEF: | ||
| raise UserWarning('Aircraft.Fuselage.SEAT_WIDTH_ECONOMY is not set.') |
Contributor
There was a problem hiding this comment.
Does it default? If so we should let the user know what value it defaulted to.
Contributor
Author
There was a problem hiding this comment.
GASP does not have a default value. This will throw an error message. Maybe, we can take the FLOPS default (20 inches)? @cmbenne3
Contributor
There was a problem hiding this comment.
I think this is either:
- a required input (in which case we should error if it is not set, regardless of verbosity).
- an input which is defaulted if not set (In this case we should tell the user that we are setting it for them. I would use the FLOPS default if GASP doesn't have one.)
I think I prefer option 2.
jkirk5
reviewed
Jul 10, 2026
jkirk5
left a comment
jkirk5
left a comment
Contributor
There was a problem hiding this comment.
Some additional comments, full review WIP
Comment on lines
+110
to
+112
| if design_type == AircraftTypes.BLENDED_WING_BODY: | ||
| if verbosity >= Verbosity.BRIEF: | ||
| raise UserWarning('Aircraft.Fuselage.SEAT_WIDTH_ECONOMY is not set.') |
Contributor
There was a problem hiding this comment.
As far as I can tell there isn't a reason to raise an error if this variable is missing, I don't think we need these lines
Contributor
Author
There was a problem hiding this comment.
GASP does not have a default value. It we read from a GASP input file, we may set Aircraft.Fuselage.SEAT_WIDTH_ECONOMY and will be set to 0.0. Are you sure we don't need this line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For FLOPS based geometry, business seats are added to transporter aircraft. For GASP based geometry, business class seats are added to BWB aircraft. In both cases, users can set:
For FLOPS based models, there will be differences of fuselage layout if business class seats are included for transporter aircraft because FLOPS does not consider business seats in its layout algorithm. This message is added to the top of output .csv file.
GASP based geometry does not have a detailed layout for transporter aircraft. We do not add this feature in this PR.
Related Issues
Backwards incompatibilities
None
New Dependencies
None