From 7b2c15d8246eed551dd74d5782c015c61401dc32 Mon Sep 17 00:00:00 2001 From: BattleMoench Date: Mon, 13 Apr 2020 22:03:46 +0200 Subject: [PATCH] Update ConfigImport.php only deactivate module if it is activated. We can run into the case, that a not activated module is updated to a newer version. Then we run into a ModuleSetupException. See https://github.com/OXID-eSales/oxideshop_ce/blob/e454b1de3a675ba023bc4e2c76eb626a0ac1e794/source/Internal/Framework/Module/Setup/Service/ModuleActivationService.php#L121 --- Core/ConfigImport.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Core/ConfigImport.php b/Core/ConfigImport.php index 39cc140..da1055e 100644 --- a/Core/ConfigImport.php +++ b/Core/ConfigImport.php @@ -322,8 +322,10 @@ protected function importConfigValues($aConfigValues) // "[NOTE] {$sModuleId} current version is $cv" //); } - $disabledModulesBeforeImport[$sModuleId] = 'disabledByUpdate'; - $oModuleStateFixer->deactivate($oModule); + if($oModule->isActive()) { + $disabledModulesBeforeImport[$sModuleId] = 'disabledByUpdate'; + $oModuleStateFixer->deactivate($oModule); + } } }