Unified aero recipe: optional shared reader cache - #2016
Draft
coreyjadams wants to merge 2 commits into
Draft
coreyjadams wants to merge 2 commits into
coreyjadams wants to merge 2 commits into
Conversation
Signed-off-by: Corey Adams <6619961+coreyjadams@users.noreply.github.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Corey Adams <6619961+coreyjadams@users.noreply.github.com>
Contributor
CODEOWNERS review mapCurrent for commit ⏳ @coreyjadams — 6 file(s)
⏳ @peterdsharpe — 6 file(s)
Comment |
This was referenced Sep 23, 2026
coreyjadams
added this pull request to stack #2018
September 23, 2026 20:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Wires the optional reader cache into the unified external aerodynamics recipe. A
dataloader.cacheconfig block (off by default; the example pointsdisk_dirunder$TMPDIR), one sharedDatasetCachebuilt inbuild_dataloadersand passed to every dataset,MeshReaderWithGlobalDatarouting its external global-data load through it, and per-epochcache.stats()in the existingbenchmark_iomode. Two recipe tests.This is the branch the I/O benchmark matrix runs on (main / pread / cache / both,
benchmark_io=true, epoch-2 throughput).Checklist
Stack
preadvin the mesh readers (Max Khitrov, from fork)mainio-01-preadio-02-cache-coreio-03-cache-readersio-04-recipeEach PR shows only its own commits. Merge bottom-up; after each merge, retarget the next PR to
main. Supersedes #1872.🤖 Generated with Claude Code