Skip to content

Remove physicsnemo compatibility layer - #1997

Merged
coreyjadams merged 7 commits into
NVIDIA:mainfrom
coreyjadams:refactor/remove-v1-compat-layer
Sep 22, 2026
Merged

coreyjadams merged 7 commits into
NVIDIA:mainfrom
coreyjadams:refactor/remove-v1-compat-layer

Conversation

@coreyjadams

Copy link
Copy Markdown
Collaborator

PhysicsNeMo Pull Request

We are now in version v2.3, it is safe to remove the v2.0 compatibility shims.

Description

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

@copy-pr-bot

copy-pr-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS review map

Current for commit 62ba7487e85e. An approval covers every file listed for that owner; one owner is sufficient for shared files.

⏳ @megnvidia — 1 file(s)
  • v2.0-MIGRATION-GUIDE.md
⏳ @ram-cherukuri — 1 file(s)
  • v2.0-MIGRATION-GUIDE.md

No CODEOWNER

  • .importlinter
  • CHANGELOG.md
  • physicsnemo/init.py
  • physicsnemo/compat/init.py
  • skills/physicsnemo-discover/references/RECIPES.md
  • test/compat/init.py
  • test/compat/test_compat.py

Comment /codeowners-info to refresh.

@greptile-apps

greptile-apps Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Retrigger

The code removal appears safe to merge, but the migration documentation and discovery fallback should be corrected so users can reliably translate removed import paths.

Findings

  1. P2 Missing Rename Tables ▶
  2. P2 Function Fallback Uses Class Placeholder ▶

Summary

This PR removes the opt-in pre-v2.0 import compatibility layer, its activation environment variable, import-linter configuration, and dedicated tests. It also updates release and migration documentation plus the discovery skill’s renamed-API fallback.

  • The compatibility implementation and all remaining in-repository callers are removed consistently.
  • The migration guide does not retain the deleted old-to-new mapping data despite directing users to rename tables.
  • The discovery recipe’s shared class/function fallback uses a class-only placeholder.

Reviews (1) · Last reviewed commit: "Remove physicsnemo compatibility layer f..."

Comment thread v2.0-MIGRATION-GUIDE.md Outdated
Comment thread skills/physicsnemo-discover/references/RECIPES.md Outdated

@ktangsali ktangsali left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor comment.

Comment thread skills/physicsnemo-discover/references/RECIPES.md Outdated
@coreyjadams

Copy link
Copy Markdown
Collaborator Author

/ok to test c948086

@megnvidia megnvidia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve pending accepting suggested changes

Comment thread v2.0-MIGRATION-GUIDE.md Outdated
Comment thread v2.0-MIGRATION-GUIDE.md Outdated
Comment thread skills/physicsnemo-discover/references/RECIPES.md Outdated
coreyjadams and others added 4 commits September 22, 2026 14:15
Co-authored-by: megnvidia <mmiranda@nvidia.com>
Co-authored-by: megnvidia <mmiranda@nvidia.com>
Co-authored-by: megnvidia <mmiranda@nvidia.com>
@coreyjadams

Copy link
Copy Markdown
Collaborator Author

/ok to test fab4609

@coreyjadams
coreyjadams added this pull request to the merge queue Sep 22, 2026
Merged via the queue into NVIDIA:main with commit 426f755 Sep 22, 2026
13 checks passed
@coreyjadams
coreyjadams deleted the refactor/remove-v1-compat-layer branch September 22, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants