Remove physicsnemo compatibility layer - #1997
Conversation
CODEOWNERS review mapCurrent for commit ⏳ @megnvidia — 1 file(s)
⏳ @ram-cherukuri — 1 file(s)
No CODEOWNER
Comment |
|
The code removal appears safe to merge, but the migration documentation and discovery fallback should be corrected so users can reliably translate removed import paths. FindingsSummaryThis PR removes the opt-in pre-v2.0 import compatibility layer, its activation environment variable, import-linter configuration, and dedicated tests. It also updates release and migration documentation plus the discovery skill’s renamed-API fallback.
Reviews (1) · Last reviewed commit: "Remove physicsnemo compatibility layer f..." |
ktangsali
left a comment
There was a problem hiding this comment.
LGTM! Just a minor comment.
|
/ok to test c948086 |
megnvidia
left a comment
There was a problem hiding this comment.
approve pending accepting suggested changes
Co-authored-by: megnvidia <mmiranda@nvidia.com>
Co-authored-by: megnvidia <mmiranda@nvidia.com>
Co-authored-by: megnvidia <mmiranda@nvidia.com>
|
/ok to test fab4609 |
PhysicsNeMo Pull Request
We are now in version v2.3, it is safe to remove the v2.0 compatibility shims.
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.