11import { expect , it , vi } from 'vitest' ;
22import { IgnitionEnv } from '../src/ignition-env' ;
3+ import type { TrainingEnv } from '../src/types' ;
4+
5+ function baseWorld ( ) {
6+ return {
7+ actions : 2 ,
8+ observe : ( ) => [ 0 ] ,
9+ step : ( ) => { } ,
10+ reward : ( ) => 0 ,
11+ reset : ( ) => { } ,
12+ } ;
13+ }
14+
15+ async function stepWith ( world : object ) {
16+ const loop = new IgnitionEnv ( { ...baseWorld ( ) , ...world } as TrainingEnv ) ;
17+ loop . agent = { getAction : async ( ) => 0 , remember : ( ) => { } , train : async ( ) => { } } ;
18+ return loop . step ( ) ;
19+ }
320
421it . each ( [ 'step' , 'inferStep' ] as const ) ( '%s reports truncation and resets without losing the last observation' , async ( method ) => {
522 let position = 0 ;
@@ -16,6 +33,62 @@ it.each(['step', 'inferStep'] as const)('%s reports truncation and resets withou
1633 if ( method === 'step' ) expect ( remember ) . toHaveBeenCalledWith ( expect . objectContaining ( { nextState : [ 5 ] , terminated : false , truncated : true } ) ) ;
1734} ) ;
1835
36+ it ( 'canonical terminated() alone sets terminated' , async ( ) => {
37+ expect ( await stepWith ( { done : ( ) => false , terminated : ( ) => true } ) ) . toMatchObject ( { terminated : true , truncated : false } ) ;
38+ } ) ;
39+
40+ it ( 'alias isTerminated() alone sets terminated' , async ( ) => {
41+ expect ( await stepWith ( { done : ( ) => false , isTerminated : ( ) => true } ) ) . toMatchObject ( { terminated : true , truncated : false } ) ;
42+ } ) ;
43+
44+ it ( 'prefers canonical terminated() over isTerminated() when both are defined' , async ( ) => {
45+ const terminated = vi . fn ( ( ) => false ) ;
46+ const isTerminated = vi . fn ( ( ) => true ) ;
47+ expect ( await stepWith ( { done : ( ) => true , terminated, isTerminated } ) ) . toMatchObject ( { terminated : false , truncated : false } ) ;
48+ expect ( terminated ) . toHaveBeenCalledTimes ( 1 ) ;
49+ expect ( isTerminated ) . not . toHaveBeenCalled ( ) ;
50+ } ) ;
51+
52+ it ( 'canonical truncated() alone sets truncated' , async ( ) => {
53+ expect ( await stepWith ( { done : ( ) => false , truncated : ( ) => true } ) ) . toMatchObject ( { terminated : false , truncated : true } ) ;
54+ } ) ;
55+
56+ it ( 'alias isTruncated() alone sets truncated' , async ( ) => {
57+ expect ( await stepWith ( { done : ( ) => false , isTruncated : ( ) => true } ) ) . toMatchObject ( { terminated : false , truncated : true } ) ;
58+ } ) ;
59+
60+ it ( 'prefers canonical truncated() over isTruncated() when both are defined' , async ( ) => {
61+ const truncated = vi . fn ( ( ) => false ) ;
62+ const isTruncated = vi . fn ( ( ) => true ) ;
63+ expect ( await stepWith ( { done : ( ) => false , truncated, isTruncated } ) ) . toMatchObject ( { terminated : false , truncated : false } ) ;
64+ expect ( truncated ) . toHaveBeenCalledTimes ( 1 ) ;
65+ expect ( isTruncated ) . not . toHaveBeenCalled ( ) ;
66+ } ) ;
67+
68+ it ( 'canonical done() alone sets terminated' , async ( ) => {
69+ expect ( await stepWith ( { done : ( ) => true } ) ) . toMatchObject ( { terminated : true , truncated : false } ) ;
70+ } ) ;
71+
72+ it ( 'alias isDone() alone sets terminated' , async ( ) => {
73+ expect ( await stepWith ( { isDone : ( ) => true } ) ) . toMatchObject ( { terminated : true , truncated : false } ) ;
74+ } ) ;
75+
76+ it ( 'prefers canonical done() over isDone() when both are defined' , async ( ) => {
77+ const done = vi . fn ( ( ) => false ) ;
78+ const isDone = vi . fn ( ( ) => true ) ;
79+ expect ( await stepWith ( { done, isDone } ) ) . toMatchObject ( { terminated : false , truncated : false } ) ;
80+ expect ( done ) . toHaveBeenCalledTimes ( 1 ) ;
81+ expect ( isDone ) . not . toHaveBeenCalled ( ) ;
82+ } ) ;
83+
84+ it ( 'honors isTerminated/isTruncated aliases over done()' , async ( ) => {
85+ const reset = vi . fn ( ) ;
86+ expect ( await stepWith ( {
87+ done : ( ) => true , reset, isTerminated : ( ) => false , isTruncated : ( ) => true ,
88+ } ) ) . toMatchObject ( { terminated : false , truncated : true } ) ;
89+ expect ( reset ) . toHaveBeenCalledTimes ( 1 ) ;
90+ } ) ;
91+
1992it . each ( [
2093 { explicit : undefined , truncated : undefined , terminal : true , cut : false } ,
2194 { explicit : true , truncated : true , terminal : true , cut : true } ,
@@ -32,8 +105,11 @@ it.each([
32105 expect ( reset ) . toHaveBeenCalledTimes ( terminal || cut ? 1 : 0 ) ;
33106} ) ;
34107
35- it . each ( [ 'terminated' , 'truncated' ] ) ( 'rejects a non-function %s callback at construction' , ( name ) => {
36- expect ( ( ) => new IgnitionEnv ( { actions : 2 , observe : ( ) => [ 0 ] , step : ( ) => { } ,
37- reward : ( ) => 0 , done : ( ) => false , reset : ( ) => { } , [ name ] : true ,
38- } ) ) . toThrow ( new RegExp ( name ) ) ;
39- } ) ;
108+ it . each ( [ 'terminated' , 'truncated' , 'isTerminated' , 'isTruncated' , 'isDone' ] ) (
109+ 'rejects a non-function %s callback at construction' ,
110+ ( name ) => {
111+ expect ( ( ) => new IgnitionEnv ( { actions : 2 , observe : ( ) => [ 0 ] , step : ( ) => { } ,
112+ reward : ( ) => 0 , done : ( ) => false , reset : ( ) => { } , [ name ] : true ,
113+ } ) ) . toThrow ( new RegExp ( name ) ) ;
114+ } ,
115+ ) ;
0 commit comments