Skip to content

Decoders not running continously #728

Open

Description

@c0d3z3r0

I would expect a decoder (e.g. I2C) to run continuosly during capturing. However, decoding only takes place when either a) stopping the capture or b) hit the decoder settings button (not changing anything!).

image

Activity

  1. dreamsource-tai commented on Jan 22, 2024

    @dreamsource-tai
    Collaborator

    @c0d3z3r0
    What is your DSView version?
    The v1.3.1 version, on stream mode, the decoder works during capturing.

  2. c0d3z3r0 commented on Jan 22, 2024

    @c0d3z3r0
    Author

    Oh sorry, I forgot to mention the version. I tried v1.3.1 on both Windows and Linux and see the same problem

  3. c0d3z3r0 commented on Jan 22, 2024

    @c0d3z3r0
    Author

    Here is a demonstration of the problem

    simplescreenrecorder-2024-01-22_09.07.17.mp4
  4. dreamsource-tai commented on Jan 23, 2024

    @dreamsource-tai
    Collaborator

    @c0d3z3r0
    From the video you provided, it can be seen that your acquisition time is 57 minutes, so the decoding progress will be slower throughout the entire acquisition process. You can set the time lower to verify that the decoder has been working continuously during the acquisition process.

  5. c0d3z3r0 commented on Jan 23, 2024

    @c0d3z3r0
    Author

    Why does the maximum acquisition time slow down the decoding process? In my video you see that decoding happens instantly when clicking the settings button. Shouldn't the decoder be triggered each time any of the signals change?

    Update: You were right about the decoder itself. I have added some debug print statements and the decoder continuously is being fed with new data and sends it to DSView through putx. That means, there is a problem in the GUI not updating the decoded data table continuously.

  6. c0d3z3r0 commented on Jan 23, 2024

    @c0d3z3r0
    Author

    Another update: I found the source of the problem. The table (protocol dock) only gets updated in 10% steps:

    https://github.com/DreamSourceLab/DSView/blob/master/DSView/pv/dock/protocoldock.cpp#L480

    Probably it would be better to bind update_model() to the signal decode_done. I tried to do it, but I'm not familiar with Qt signals...

  7. dreamsource-tai commented on Jan 24, 2024

    @dreamsource-tai
    Collaborator

    @c0d3z3r0
    During the collection process, if the collection is stopped midway, the decoding task can immediately end because the data volume has been determined. However, during the one hour collection process, the data volume continues to approach the total data volume, which takes an hour to complete, so the decoding progress will be slower.

  8. c0d3z3r0 commented on Jan 24, 2024

    @c0d3z3r0
    Author

    You can clearly see in the video that it's just a view update issue. Did you even read my previous comment?

    The problem is that binding decoding to the percentage update signal (each 10%) does not make any sense. That is the reason why it's "slower". However, not decoding is slower but only updating the view.

    To fix this, update_model() should be bound to decode_done() instead. I just don't know how to do it bc I'm not an Qt expert.

  9. added a commit that references this issue on Jan 24, 2024
    b9288b1
  10. c0d3z3r0 commented on Jan 24, 2024

    @c0d3z3r0
    Author

    I managed to fix this...

    Previous behaviour:

    298507295-37801f22-8a5e-419c-848e-dec77adf72ed.mp4

    New behaviour:

    simplescreenrecorder-2024-01-24_14.46.57.mp4
  11. dreamsource-tai commented on Jan 25, 2024

    @dreamsource-tai
    Collaborator

    @c0d3z3r0
    Sometimes, decoding generates a large amount of model data, so it is necessary to control the refresh rate.

  12. c0d3z3r0 commented on Apr 8, 2024

    @c0d3z3r0
    Author

    Maybe it would be possible to check the amount of data and limit refresh rate based on that. This way, slow communication via e.g. I2C can still be seen in more-or-less real-time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions