Skip to content

NOTICE.md

Latest commit

 

History

History
66 lines (55 loc) · 7.2 KB

NOTICE.md

File metadata and controls

66 lines (55 loc) · 7.2 KB
Raw

NOTICE

This repository is a fork of ChenDarYen/ComfyUI-NAG, the upstream implementation of Normalized Attention Guidance (NAG) for ComfyUI by Dar-Yen Chen. The original work, including all node implementations under chroma/, flux/, hidream/, hunyuan_video/, sd/, sd3/, wan/, samplers.py, node.py, sample.py, and utils.py, is the sole intellectual property of the upstream author and is licensed under the terms in LICENSE (MIT). The upstream LICENSE file is unmodified in this fork.

Why this fork exists

Upstream had no commits between 2025-11-03 and the time this fork was made, while ComfyUI itself continued to move forward (v0.21+). Several user-reported incompatibility issues (#58, #62, #63, #68, #79) remained without maintainer response. This fork carries small compatibility patches so the node keeps working on current ComfyUI builds, while leaving the algorithmic implementation and parameter semantics untouched.

Modifications relative to upstream HEAD (ef8a641)

Date (ISO) Commit Change Files Author
2026-05-20 0920a10 Handle None stubs at comfy.ldm.chroma.layers.DoubleStreamBlock / SingleStreamBlock in ComfyUI v0.21+ via fallback to comfy.ldm.flux.layers. Remove dead import of the same symbols in chroma/model.py. chroma/layers.py, chroma/model.py Delcado19
2026-05-20 036e11d Fork-identity files (this NOTICE.md, README banner). NOTICE.md, README.md Delcado19
2026-05-20 8fe3449 Add pyproject.toml for ComfyUI Registry publishing under fork-specific identifier. pyproject.toml Delcado19
2026-05-20 54e2c2b Add GitHub Actions: smoke import test and ComfyUI Registry publish workflow. .github/workflows/smoke-import.yml, .github/workflows/publish.yml Delcado19
2026-05-20 3618385 Correct PublisherId to delcado and rename slug to comfyui-nag-delcado to match the registry profile handle @delcado. pyproject.toml Delcado19
2026-05-20 efcc966 Fix README Usage-section replacement direction (closes upstream #39). README.md Delcado19
2026-05-20 f048600 CI hotfix: install ComfyUI's own requirements.txt instead of a hand-curated pip list (was missing scipy). .github/workflows/smoke-import.yml Delcado19
2026-05-20 f0e5e69 → 2fd1269 CI hotfix: force CPU mode in the smoke-import job so ComfyUI's model_management.py does not call torch.cuda.current_device() on a CPU-only runner. First via sys.argv = ['comfyui', '--cpu'] (insufficient), then via direct comfy.cli_args.args.cpu = True patch. .github/workflows/smoke-import.yml Delcado19
2026-05-20 — First publish to Comfy Registry as comfyui-nag-delcado version 1.0.1. — Delcado19
2026-05-22 4e6b640 Treat missing flipped_img_txt on current ComfyUI Flux blocks as the default txt, img attention ordering, avoiding Flux / Flux Kontext AttributeError crashes. flux/layers.py, README.md, NOTICE.md Delcado19
2026-05-22 — Harden the Chroma block import fallback so future ComfyUI builds that remove the deprecated comfy.ldm.chroma.layers path still fall back to comfy.ldm.flux.layers. chroma/layers.py, README.md, NOTICE.md Delcado19
2026-05-22 — Make the Flux NAG wrapper derive text positional-ID dimensions from the loaded model, fixing Flux2 / Flux.2 klein models that use four-axis IDs instead of the older three-axis Flux assumption. flux/model.py, README.md, NOTICE.md Delcado19
2026-05-22 — Keep Flux2 / Flux.2 klein gated-MLP and four-axis-ID models on the ComfyUI core single-stream path with combined RoPE data while NAG remains active in the double-stream path, avoiding the shape regression in the NAG single-stream wrapper. flux/model.py, README.md, NOTICE.md Delcado19
2026-05-22 — Left-pad the txt portion of pe / pe_negative to the shared padded txt length before stacking over batch in the Flux2 core single-stream path, fixing RuntimeError: Sizes of tensors must match except in dimension 0. Expected size 6052 but got size 4388 when the positive and negative contexts have different unpadded token counts (e.g. Flux.2 klein 9B NAG workflows). flux/model.py, README.md, NOTICE.md Delcado19
2026-05-22 — Normalize direct NAG negative conditioning for batched custom sampler runs and replace zero-token NAG negatives with a minimal zero-token fallback, avoiding shape '[2, 0, 4096]' is invalid for input of size 4096 crashes. Ensure NAG model-forward patches are restored even when sampling raises. samplers.py, README.md, NOTICE.md Delcado19
2026-05-22 — Add a neutral Flux vector fallback when Flux2/GGUF negative text conditioning has no pooled CLIP output and preserve no-vector Flux2 models by skipping vector conditioning, avoiding SamplerCustomAdvanced crashes with 'NoneType' object has no attribute 'to'. Restore temporary Flux block patches with finally so failed sampling does not leave the model in a patched state. flux/model.py, README.md, NOTICE.md Delcado19
2026-05-22 — Route Flux2 global-modulation double-stream blocks through ComfyUI's tuple-based modulation path and slice the image modulation to the positive batch, avoiding missing img_mod / txt_mod attribute crashes in NAG double-stream sampling. flux/model.py, flux/layers.py, README.md, NOTICE.md Delcado19
2026-05-22 — Preserve each Flux model's patch_size when reshaping NAG outputs and pass optional Flux forward arguments by keyword, fixing Flux2 128-channel latent output and current ComfyUI signature compatibility without disabling NAG. flux/model.py, README.md, NOTICE.md Delcado19
2026-05-23 — Add ComfyUI node-input descriptions for the NAG parameter ranges and document the same minimum, maximum, and default values in the README. node.py, README.md, NOTICE.md Delcado19
2026-05-23 — Publish the synchronized compatibility and documentation state as registry version 1.0.2; keep the README support list aligned with the implemented HiDream switch. pyproject.toml, README.md, NOTICE.md Delcado19

Upstream tracking

  • Upstream remote is preserved as upstream in this repo's working copy: git remote get-url upstream -> https://github.com/ChenDarYen/ComfyUI-NAG.git
  • To incorporate future upstream changes: git fetch upstream && git merge upstream/main

Possible future work

  • Z-Image / Z-Image Turbo support would likely need a dedicated Lumina / NextDiT NAG switch, because the current sampler dispatch only covers Flux, Chroma, UNetModel, OpenAISignatureMMDITWrapper, Wan, HunyuanVideo, and HiDream.
  • The current code paths do not route comfy.ldm.lumina.model.NextDiT through NAG yet, so Z-Image-family work remains a future compatibility task rather than an implemented feature.

License

The MIT license in LICENSE covers both the upstream code and the modifications listed above. Modifications are contributed under the same MIT terms.