Skip to content

JCF: DUNE-DAQ/dfmodules#496: add a class derived from DataStoreConf f… - #294

Closed
jcfreeman2 wants to merge 1 commit into
developfrom
johnfreeman/file_formats_refactor
Closed

JCF: DUNE-DAQ/dfmodules#496: add a class derived from DataStoreConf f…#294
jcfreeman2 wants to merge 1 commit into
developfrom
johnfreeman/file_formats_refactor

Conversation

@jcfreeman2

Copy link
Copy Markdown
Contributor

…or the proof-of-concept data store implementation in dfmodules

Description

This draft PR is needed for the primary draft PR, DUNE-DAQ/dfmodules#497, to build

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

…or the proof-of-concept data store implementation in dfmodules
@eflumerf

Copy link
Copy Markdown
Member

This definitely seems like a place where good naming practice is essential.

@jcfreeman2
jcfreeman2 marked this pull request as ready for review August 5, 2026 18:55
@jcfreeman2

Copy link
Copy Markdown
Contributor Author

This is to be merged in concert with the feature branches of the same name in hdf5libs and dfmodules.

@eflumerf

eflumerf commented Aug 10, 2026

Copy link
Copy Markdown
Member

This appears to be simply a test of functionality, as such, should it be defined in dfmodules/test/datastore_derived.schema.xml ? (Or hdf5libs/test if that is lower on the dependency tree)

@jcfreeman2 jcfreeman2 closed this Aug 11, 2026
@jcfreeman2
jcfreeman2 deleted the johnfreeman/file_formats_refactor branch August 11, 2026 18:29
@jcfreeman2

Copy link
Copy Markdown
Contributor Author

See my update to DUNE-DAQ/dfmodules#497 which addresses this; I've added a datastore_derived.schema.xml now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants