JCF: DUNE-DAQ/dfmodules#496: add a class derived from DataStoreConf f… - #294
Closed
jcfreeman2 wants to merge 1 commit into
Closed
JCF: DUNE-DAQ/dfmodules#496: add a class derived from DataStoreConf f…#294jcfreeman2 wants to merge 1 commit into
jcfreeman2 wants to merge 1 commit into
Conversation
…or the proof-of-concept data store implementation in dfmodules
Member
|
This definitely seems like a place where good naming practice is essential. |
jcfreeman2
marked this pull request as ready for review
August 5, 2026 18:55
Contributor
Author
|
This is to be merged in concert with the feature branches of the same name in |
Member
|
This appears to be simply a test of functionality, as such, should it be defined in |
Contributor
Author
|
See my update to DUNE-DAQ/dfmodules#497 which addresses this; I've added a |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or the proof-of-concept data store implementation in dfmodules
Description
This draft PR is needed for the primary draft PR, DUNE-DAQ/dfmodules#497, to build
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))