Skip to content

Commit 17d83df

Browse files
authored
Merge pull request #6503 from ConductionNL/quality/arch-independence-2
refactor(kernel): two contract getters return contracts
2 parents 959c3c2 + edebd53 commit 17d83df

3 files changed

Lines changed: 15 additions & 6 deletions

File tree

‎lib/Kernel/Contracts/DocumentRelevanceInterface.php‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
namespace OCA\Dossiq\Kernel\Contracts;
2424

2525
use OCA\Dossiq\Exception\RefusedException;
26-
use OCA\Dossiq\Review\PagesSeen;
2726

2827
/**
2928
* Contract of DocumentRelevance.
@@ -92,11 +91,11 @@ public function markInScopeWhereUnmarked(string $caseId, array $documentRefs, st
9291
/**
9392
* The pages seen on these reviews, and the required pages still unseen.
9493
*
95-
* @return PagesSeen The pages seen, over these reviews.
94+
* @return PagesSeenInterface The pages seen, over these reviews.
9695
*
9796
* @spec openspec/changes/woo-review-triage/specs/document-review/spec.md#requirement-nothing-is-decided-or-published-before-the-required-pages-are-seen-req-wrt-005
9897
*/
99-
public function pages(): PagesSeen;
98+
public function pages(): PagesSeenInterface;
10099

101100
/**
102101
* Save a review, creating or replacing it.

‎lib/Kernel/Contracts/PagesSeenInterface.php‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,4 +83,15 @@ public function assertAllSeen(string $caseId): void;
8383
* @spec openspec/changes/woo-review-triage/specs/document-review/spec.md#requirement-nothing-is-decided-or-published-before-the-required-pages-are-seen-req-wrt-005
8484
*/
8585
public function unseenInCase(string $caseId): array;
86+
/**
87+
* The refusal of a verdict on an in-scope document whose required pages are not all seen.
88+
*
89+
* @param string $caseId The case UUID.
90+
* @param array<string, mixed> $assessment The assessment.
91+
*
92+
* @return array<string, string> `['pagesSeen' => sentence]`, or empty.
93+
*
94+
* @spec openspec/changes/woo-review-triage/specs/document-review/spec.md#requirement-nothing-is-decided-or-published-before-the-required-pages-are-seen-req-wrt-005
95+
*/
96+
public function refusalFor(string $caseId, array $assessment): array;
8697
}//end interface

‎lib/Kernel/Contracts/ZgwServiceInterface.php‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424

2525
use OCA\Dossiq\Kernel\Contracts\ZgwBusinessRulesServiceInterface;
2626
use OCA\Dossiq\Kernel\Contracts\ZgwDocumentServiceInterface;
27-
use OCA\Dossiq\Service\ZgwMappingService;
2827
use OCA\OpenRegister\Db\Mapping;
2928
use OCP\AppFramework\Http\JSONResponse;
3029
use OCP\IRequest;
@@ -260,11 +259,11 @@ public function getRequestBody(IRequest $request): array;
260259
/**
261260
* Get the ZGW mapping service.
262261
*
263-
* @return ZgwMappingService
262+
* @return ZgwMappingServiceInterface
264263
*
265264
* @spec openspec/specs/zgw-api-mapping/spec.md
266265
*/
267-
public function getZgwMappingService(): ZgwMappingService;
266+
public function getZgwMappingService(): ZgwMappingServiceInterface;
268267

269268
/**
270269
* Handle audit trail index — proxies to OpenRegister's audit trail.

0 commit comments

Comments
 (0)