Skip to content
This repository was archived by the owner on Dec 27, 2023. It is now read-only.
This repository was archived by the owner on Dec 27, 2023. It is now read-only.

Default value for $scale should not be null (arccos, arctan, arcsec, arccsc, tan, cotan etc.) #68

Description

@gregor-tb

public function arccos(int $scale = null): Decimal

$scale is null here by default, but used like (int) 0. This is working in the additions $scale + 2 etc., but crashes on calling round(int) method, which does not accept null.

But later it is checked for explicit null value

$scale = ($scale === null) ? 32 : $scale;

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions