From 54506ed25b47a216524af2db90b0e2db032f6d75 Mon Sep 17 00:00:00 2001 From: Wouter van der Laan Date: Fri, 13 Nov 2026 11:32:56 +0100 Subject: [PATCH 1/2] refactor: rename 'vignet' to 'vignette' across the boat charging module --- src/modules/boat-charging/alerts.ts | 26 +++---- .../BoatChargingConfirmSessionDetails.tsx | 37 ++++----- ...BoatChargingConfirmSessionSubmitButton.tsx | 32 ++++---- .../components/BoatChargingGuestEmailForm.tsx | 4 +- .../BoatChargingHistorySessionDetails.tsx | 2 +- .../session/BoatChargingSession.tsx | 2 +- .../BoatChargingAddVignetHeaderButton.tsx | 8 +- .../vignettes/BoatChargingMyVignettes.tsx | 14 ++-- .../vignettes/BoatChargingVignetListItem.tsx | 12 +-- .../form/BoatChargingChooseVignetForm.tsx | 30 ++++---- ...atChargingChooseVignetFormSubmitButton.tsx | 16 ++-- .../vignettes/form/BoatChargingVignetForm.tsx | 76 ++++++++++--------- ...argingVignetFormAddToMyVignettesSwitch.tsx | 8 +- .../BoatChargingVignetFormAddVignetButton.tsx | 36 ++++----- ...atChargingVignetFormDeleteVignetButton.tsx | 24 +++--- ...BoatChargingVignetFormEditVignetButton.tsx | 36 ++++----- ...atChargingVignetFormVerifyVignetButton.tsx | 62 +++++++-------- .../BoatChargingVignetNumberFormInput.tsx | 6 +- .../BoatChargingVignetPostalCodeFormInput.tsx | 4 +- .../vignetInvalidReasonToAlertMap.ts | 18 ++--- .../boat-charging/hooks/useInitSession.ts | 14 ++-- .../hooks/useInitSessionNextStep.test.ts | 70 ++++++++--------- .../hooks/useInitSessionNextStep.ts | 20 ++--- .../BoatChargingVignetForm.provider.tsx | 14 ++-- src/modules/boat-charging/routes.ts | 14 ++-- src/modules/boat-charging/screenConfig.ts | 28 +++---- .../BoatChargingChooseVignet.screen.tsx | 12 +-- .../BoatChargingVerifyVignet.screen.tsx | 20 ++--- .../screens/BoatChargingVignet.screen.tsx | 12 +-- src/modules/boat-charging/service.ts | 43 ++++++----- src/modules/boat-charging/types.ts | 36 ++++----- src/modules/redirects/exports/RedirectKey.ts | 4 +- 32 files changed, 373 insertions(+), 367 deletions(-) diff --git a/src/modules/boat-charging/alerts.ts b/src/modules/boat-charging/alerts.ts index d52d0a9aa..d375a111f 100644 --- a/src/modules/boat-charging/alerts.ts +++ b/src/modules/boat-charging/alerts.ts @@ -98,44 +98,44 @@ export const alerts = { title: 'Inloggen lukt niet', testID: 'BoatChargingLoginFailedAlert', }, - vignetInvalidFailed: { + vignetteInvalidFailed: { variant: AlertVariant.negative, text: 'Dit vignet is niet geldig.', title: 'Niet geldig', - testID: 'BoatChargingVignetInvalidAlert', + testID: 'BoatChargingVignetteInvalidAlert', }, - vignetDeleteFailed: { + vignetteDeleteFailed: { variant: AlertVariant.negative, text: 'Het vignet is niet verwijderd. Probeer het later nog eens.', title: 'Er ging iets mis', - testID: 'BoatChargingVignetDeleteAlert', + testID: 'BoatChargingVignetteDeleteAlert', }, - vignetExpiredFailed: { + vignetteExpiredFailed: { variant: AlertVariant.negative, text: 'Dit vignet is niet meer geldig.', title: 'Dit vignet is verlopen', - testID: 'BoatChargingVignetExpiredAlert', + testID: 'BoatChargingVignetteExpiredAlert', }, - vignetNotApplicableFailed: { + vignetteNotApplicableFailed: { variant: AlertVariant.negative, externalLink: { label: 'Bekijk welk vignet u nodig heeft', - redirectKey: RedirectKey.boatChargingVignetInfo, + redirectKey: RedirectKey.boatChargingVignetteInfo, }, title: 'Met dit vignet kunt u niet laden', - testID: 'BoatChargingVignetNotApplicableAlert', + testID: 'BoatChargingVignetteNotApplicableAlert', }, - vignetAlreadyInUseFailed: { + vignetteAlreadyInUseFailed: { variant: AlertVariant.negative, text: 'Er is al een actieve laadsessie met dit vignet. Controleer uw actieve laadsessies.', title: 'Vignet is al in gebruik', - testID: 'BoatChargingVignetAlreadyInUseAlert', + testID: 'BoatChargingVignetteAlreadyInUseAlert', }, - vignetVerificationErrorFailed: { + vignetteVerificationErrorFailed: { variant: AlertVariant.negative, title: 'Vignet controleren is niet gelukt', text: 'Probeer het opnieuw.', - testID: 'BoatChargingVignetVerificationFailedAlert', + testID: 'BoatChargingVignetteVerificationFailedAlert', }, } as const satisfies AlertsRecord diff --git a/src/modules/boat-charging/components/BoatChargingConfirmSessionDetails.tsx b/src/modules/boat-charging/components/BoatChargingConfirmSessionDetails.tsx index c340305e3..27b607399 100644 --- a/src/modules/boat-charging/components/BoatChargingConfirmSessionDetails.tsx +++ b/src/modules/boat-charging/components/BoatChargingConfirmSessionDetails.tsx @@ -20,22 +20,23 @@ import { useBoatChargingVignettesQuery, } from '@/modules/boat-charging/service' import type { - BaseVignet, + BaseVignette, NewSessionFormValues, - Vignet, + Vignette, } from '@/modules/boat-charging/types' import {RedirectKey} from '@/modules/redirects/exports/RedirectKey' import {formatNumber} from '@/utils/formatNumber' -const isVignet = (vignet?: BaseVignet | Vignet | null): vignet is Vignet => - !!vignet && 'id' in vignet +const isVignette = ( + vignette?: BaseVignette | Vignette | null, +): vignette is Vignette => !!vignette && 'id' in vignette export const BoatChargingConfirmSessionDetails = () => { const form = useFormContext() const navigation = useNavigation() const {isLoggedIn} = useIsLoggedIn() - const {selectedSocket, vignet, email} = form.getValues() + const {selectedSocket, vignette, email} = form.getValues() const {data: vignettes} = useBoatChargingVignettesQuery(undefined, { skip: !isLoggedIn, @@ -55,24 +56,24 @@ export const BoatChargingConfirmSessionDetails = () => { selectedSocket?.locationId ? selectedSocket.locationId : skipToken, ) - const onNavigateToChangeVignet = useCallback(() => { - const selectedVignet = form.getValues('vignet') + const onNavigateToChangeVignette = useCallback(() => { + const selectedVignette = form.getValues('vignette') - form.setValue('vignet', null) + form.setValue('vignette', null) if (!vignettes?.length) { - navigation.popTo(BoatChargingRouteName.verifyVignet) + navigation.popTo(BoatChargingRouteName.verifyVignette) return } if ( vignettes.length === 1 && - vignettes[0].vignette_number === selectedVignet?.vignette_number + vignettes[0].vignette_number === selectedVignette?.vignette_number ) { - navigation.popTo(BoatChargingRouteName.verifyVignet) + navigation.popTo(BoatChargingRouteName.verifyVignette) } else { - navigation.popTo(BoatChargingRouteName.chooseVignet) + navigation.popTo(BoatChargingRouteName.chooseVignette) } }, [vignettes, navigation, form]) @@ -125,16 +126,16 @@ export const BoatChargingConfirmSessionDetails = () => { - {vignet?.vignette_number} - {isVignet(vignet) && !!vignet.boat_name && ( - {vignet?.boat_name} + {vignette?.vignette_number} + {isVignette(vignette) && !!vignette.boat_name && ( + {vignette?.boat_name} )} Wijzigen diff --git a/src/modules/boat-charging/components/BoatChargingConfirmSessionSubmitButton.tsx b/src/modules/boat-charging/components/BoatChargingConfirmSessionSubmitButton.tsx index 025cedb80..37607bdbb 100644 --- a/src/modules/boat-charging/components/BoatChargingConfirmSessionSubmitButton.tsx +++ b/src/modules/boat-charging/components/BoatChargingConfirmSessionSubmitButton.tsx @@ -1,10 +1,10 @@ import {useCallback} from 'react' import {Button} from '@/components/ui/buttons/Button' import {alerts} from '@/modules/boat-charging/alerts' -import {vignetInvalidReasonToAlertMap} from '@/modules/boat-charging/constants/vignetInvalidReasonToAlertMap' +import {vignetteInvalidReasonToAlertMap} from '@/modules/boat-charging/constants/vignetInvalidReasonToAlertMap' import {useInitSession} from '@/modules/boat-charging/hooks/useInitSession' import {BoatChargingRouteName} from '@/modules/boat-charging/routes' -import {useBoatChargingVerifyVignetMutation} from '@/modules/boat-charging/service' +import {useBoatChargingVerifyVignetteMutation} from '@/modules/boat-charging/service' import {type NewSessionFormValues} from '@/modules/boat-charging/types' import {devError} from '@/processes/development' import {useAlert} from '@/store/slices/alert' @@ -17,39 +17,39 @@ export const BoatChargingConfirmSessionSubmitButton = () => { ) const [ - verifyVignet, - {isLoading: isLoadingVerifyVignet, isError: isErrorVerifyVignet}, - ] = useBoatChargingVerifyVignetMutation() + verifyVignette, + {isLoading: isLoadingVerifyVignette, isError: isErrorVerifyVignette}, + ] = useBoatChargingVerifyVignetteMutation() const onSubmit = useCallback( - async ({vignet, ...values}: NewSessionFormValues) => { - if (!vignet) { + async ({vignette, ...values}: NewSessionFormValues) => { + if (!vignette) { return } - if (!vignet.verified) { + if (!vignette.verified) { try { - const {status, reason} = await verifyVignet(vignet).unwrap() + const {status, reason} = await verifyVignette(vignette).unwrap() if (status === 'invalid') { - setAlert(alerts[vignetInvalidReasonToAlertMap[reason]]) + setAlert(alerts[vignetteInvalidReasonToAlertMap[reason]]) return } - form.setValue('vignet.verified', true) + form.setValue('vignette.verified', true) } catch (error) { devError(error) - setAlert(alerts.vignetVerificationErrorFailed) + setAlert(alerts.vignetteVerificationErrorFailed) return } } - return onPress({...values, vignet}) + return onPress({...values, vignette}) }, - [verifyVignet, onPress, setAlert, form], + [onPress, setAlert, form, verifyVignette], ) return ( @@ -60,9 +60,9 @@ export const BoatChargingConfirmSessionSubmitButton = () => { size: 'ml', isFilled: true, }} - isError={isError || isErrorVerifyVignet} + isError={isError || isErrorVerifyVignette} isLoading={ - isLoading || isLoadingVerifyVignet || form.formState.isSubmitting + isLoading || isLoadingVerifyVignette || form.formState.isSubmitting } label="Betalen en laden" onPress={form.handleSubmit(onSubmit)} diff --git a/src/modules/boat-charging/components/BoatChargingGuestEmailForm.tsx b/src/modules/boat-charging/components/BoatChargingGuestEmailForm.tsx index 37c9560e2..5f76c2ec1 100644 --- a/src/modules/boat-charging/components/BoatChargingGuestEmailForm.tsx +++ b/src/modules/boat-charging/components/BoatChargingGuestEmailForm.tsx @@ -44,7 +44,7 @@ export const BoatChargingGuestEmailForm = () => { Heeft u al een account? { - setPendingScreen([BoatChargingRouteName.chooseVignet]) + setPendingScreen([BoatChargingRouteName.chooseVignette]) navigation.navigate(BoatChargingRouteName.login) }} testID="BoatChargingGuestEmailFormLoginNavigationButton" @@ -74,7 +74,7 @@ export const BoatChargingGuestEmailForm = () => {