From 8e66dcf358178129156d50f05e6adaf2ce44a78b Mon Sep 17 00:00:00 2001 From: mkbadeniyi Date: Mon, 12 Oct 2026 05:53:32 +0100 Subject: [PATCH] fix(java): name the cause of a connection that fails without a message --- .../io/github/adeniyikayodee/ngpostcode/api/Client.java | 8 +++++++- .../github/adeniyikayodee/ngpostcode/api/ClientTest.java | 8 ++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/java/api/src/main/java/io/github/adeniyikayodee/ngpostcode/api/Client.java b/java/api/src/main/java/io/github/adeniyikayodee/ngpostcode/api/Client.java index 70fdc9d..3c88f03 100644 --- a/java/api/src/main/java/io/github/adeniyikayodee/ngpostcode/api/Client.java +++ b/java/api/src/main/java/io/github/adeniyikayodee/ngpostcode/api/Client.java @@ -146,7 +146,13 @@ private static String encode(String text) { } private static Result failed(Throwable error) { - String reason = error.getMessage() != null ? error.getMessage() : error.getClass().getSimpleName(); + String reason = error.getMessage(); + if (reason == null) { + // The JDK gives a failed connection no message: its cause says which kind. + Throwable cause = error.getCause(); + reason = error.getClass().getSimpleName() + + (cause != null ? ": " + cause.getClass().getSimpleName() : ""); + } return new Result.Failed<>(new TransportError(reason)); } } diff --git a/java/api/src/test/java/io/github/adeniyikayodee/ngpostcode/api/ClientTest.java b/java/api/src/test/java/io/github/adeniyikayodee/ngpostcode/api/ClientTest.java index 3f367c3..f838c5d 100644 --- a/java/api/src/test/java/io/github/adeniyikayodee/ngpostcode/api/ClientTest.java +++ b/java/api/src/test/java/io/github/adeniyikayodee/ngpostcode/api/ClientTest.java @@ -170,4 +170,12 @@ void aSilentServerTimesOutAsAValueWithoutTheKey() throws IOException { assertInstanceOf(TransportError.class, nowhere.failure()); } } + + @Test + void aRefusedConnectionSaysWhatFailed() throws IOException { + Client client = clientFor(exchange -> {}); + server.stop(0); + var failed = assertInstanceOf(Result.Failed.class, client.send(Api.lookup(CODE))); + assertTrue(failed.failure().toString().matches("ConnectException: \\w+"), failed.failure().toString()); + } }